From 52a67db629ff12c407605163bdbe3d5dfb5373f1 Mon Sep 17 00:00:00 2001 From: Alexey Lang Date: Wed, 18 Oct 2017 12:13:06 -0700 Subject: [PATCH] Fix Systrace section for Lazy View Managers Differential Revision: D6088310 fbshipit-source-id: cf14c9cc91068cfabf4e7c1bbae5df7f25e0ced3 --- .../java/com/facebook/react/uimanager/UIManagerModule.java | 6 +++--- .../react/uimanager/UIManagerModuleConstantsHelper.java | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java index 3018ccc08..1cfef61ae 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java @@ -39,7 +39,6 @@ import com.facebook.react.uimanager.debug.NotThreadSafeViewHierarchyUpdateDebugL import com.facebook.react.uimanager.events.EventDispatcher; import com.facebook.systrace.Systrace; import com.facebook.systrace.SystraceMessage; - import java.util.ArrayList; import java.util.List; import java.util.Map; @@ -245,7 +244,8 @@ public class UIManagerModule extends ReactContextBaseJavaModule implements return null; } - SystraceMessage.beginSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "constants for ViewManager") + SystraceMessage.beginSection( + Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "UIManagerModule.getConstantsForViewManager") .arg("ViewManager", targetView.getName()) .arg("Lazy", true) .flush(); @@ -263,7 +263,7 @@ public class UIManagerModule extends ReactContextBaseJavaModule implements } return null; } finally { - SystraceMessage.endSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE); + SystraceMessage.endSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE).flush(); } } diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModuleConstantsHelper.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModuleConstantsHelper.java index ad456d655..28b108a2a 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModuleConstantsHelper.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModuleConstantsHelper.java @@ -75,7 +75,8 @@ import javax.annotation.Nullable; for (ViewManager viewManager : viewManagers) { final String viewManagerName = viewManager.getName(); - SystraceMessage.beginSection(TRACE_TAG_REACT_JAVA_BRIDGE, "constants for ViewManager") + SystraceMessage.beginSection( + TRACE_TAG_REACT_JAVA_BRIDGE, "UIManagerModuleConstantsHelper.createConstants") .arg("ViewManager", viewManagerName) .arg("Lazy", false) .flush();