From 4e3a8343b353b51b716dcebbbdb14bc2f92a89c8 Mon Sep 17 00:00:00 2001 From: Tom Walters Date: Mon, 6 Jun 2016 10:20:35 -0700 Subject: [PATCH] Convert warning about keystore into warning block in SignedAPKAndroid.md Summary: The current docs page [Generating a Signed APK](https://facebook.github.io/react-native/docs/signed-apk-android.html) contains a note about keeping your generated keystore safe, but this isn't well highlighted. This commit highlights the notice in a warning blockquote to ensure people following the guide don't miss the importance of keeping the keystore safe as shown below: screen shot 2016-06-06 at 10 01 25 Closes https://github.com/facebook/react-native/pull/7948 Differential Revision: D3393005 fbshipit-source-id: e9c2666a79134eccc1b1868fe850ee896e63266e --- docs/SignedAPKAndroid.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/SignedAPKAndroid.md b/docs/SignedAPKAndroid.md index 555e4cc34..c271d4e7c 100644 --- a/docs/SignedAPKAndroid.md +++ b/docs/SignedAPKAndroid.md @@ -35,9 +35,11 @@ MYAPP_RELEASE_KEY_PASSWORD=***** These are going to be global gradle variables, which we can later use in our gradle config to sign our app. -_Note about saving the keystore: Once you publish the app on the Play Store, you will need to republish your app under a different package name (losing all downloads and ratings) if you want to change the signing key at any point. So backup your keystore and don't forget the passwords._ +> __Note about saving the keystore:__ -_Note about security: If you are not keen on storing your passwords in plaintext and you are running OSX, you can also [store your credentials in the Keychain Access app](https://pilloxa.gitlab.io/posts/safer-passwords-in-gradle/). Then you can skip the two last rows in `~/.gradle/gradle.properties`._ +> Once you publish the app on the Play Store, you will need to republish your app under a different package name (losing all downloads and ratings) if you want to change the signing key at any point. So backup your keystore and don't forget the passwords. + +_Note about security: If you are not keen on storing your passwords in plaintext and you are running OSX, you can also [store your credentials in the Keychain Access app](https://pilloxa.gitlab.io/posts/safer-passwords-in-gradle/). Then you can skip the two last rows in `~/.gradle/gradle.properties`._ ### Adding signing config to your app's gradle config