From 4d70b85f2fc5b4e2e61e724779f65b9385231ae8 Mon Sep 17 00:00:00 2001 From: Ritesh Kadmawala Date: Sun, 10 Jul 2016 05:31:26 -0700 Subject: [PATCH] Fixed the issue due to which js assets are not bundled in the apk when separate build for different CPU architectures is enabled Summary: This PR tries to fix a minor bug in `react.gradle` due to which task that bundles JS into the assets folder of the APK is not run when separate build per CPU architecture is enabled and we are using different product flavors. Closes https://github.com/facebook/react-native/pull/8675 Differential Revision: D3541348 fbshipit-source-id: 4c84f21a06a45046f84bdd8ae5c5d834ec080476 --- react.gradle | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/react.gradle b/react.gradle index ffa9e48c6..d34469ddc 100644 --- a/react.gradle +++ b/react.gradle @@ -31,7 +31,9 @@ gradle.projectsEvaluated { productFlavors.each { productFlavorName -> buildTypes.each { buildTypeName -> // Create variant and target names - def targetName = "${productFlavorName.capitalize()}${buildTypeName.capitalize()}" + def flavorNameCapitalized = "${productFlavorName.capitalize()}" + def buildNameCapitalized = "${buildTypeName.capitalize()}" + def targetName = "${flavorNameCapitalized}${buildNameCapitalized}" def targetPath = productFlavorName ? "${productFlavorName}/${buildTypeName}" : "${buildTypeName}" @@ -92,8 +94,8 @@ gradle.projectsEvaluated { currentBundleTask.dependsOn("merge${targetName}Resources") currentBundleTask.dependsOn("merge${targetName}Assets") - runBefore("processArmeabi-v7a${targetName}Resources", currentBundleTask) - runBefore("processX86${targetName}Resources", currentBundleTask) + runBefore("process${flavorNameCapitalized}Armeabi-v7a${buildNameCapitalized}Resources", currentBundleTask) + runBefore("process${flavorNameCapitalized}X86${buildNameCapitalized}Resources", currentBundleTask) runBefore("processUniversal${targetName}Resources", currentBundleTask) runBefore("process${targetName}Resources", currentBundleTask) }