From 483c45cff06e16d166ded634a257cceaddcf5024 Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Fri, 22 Jun 2018 11:54:01 -0700 Subject: [PATCH] Fabric: Shadow node shallowing was removed from preventive cloning in UIManager Summary: @public We do preventing cloning in UIManager especially to add a layer to Shadow Node source chain, so apparently there is no point illuminate that by calling `shallowSourceNode`. Reviewed By: fkgozali Differential Revision: D8585163 fbshipit-source-id: 3743edc30bf2183c420fd79ce1e59d68ceaa278b --- ReactCommon/fabric/uimanager/FabricUIManager.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/ReactCommon/fabric/uimanager/FabricUIManager.cpp b/ReactCommon/fabric/uimanager/FabricUIManager.cpp index 22aee62d6..caf2713ac 100644 --- a/ReactCommon/fabric/uimanager/FabricUIManager.cpp +++ b/ReactCommon/fabric/uimanager/FabricUIManager.cpp @@ -234,7 +234,6 @@ void FabricUIManager::appendChild(const SharedShadowNode &parentShadowNode, cons auto childComponentDescriptor = (*componentDescriptorRegistry_)[childShadowNode]; auto clonedChildShadowNode = childComponentDescriptor->cloneShadowNode(childShadowNode); auto nonConstClonedChildShadowNode = std::const_pointer_cast(clonedChildShadowNode); - nonConstClonedChildShadowNode->shallowSourceNode(); componentDescriptor->appendChild(parentShadowNode, clonedChildShadowNode); return; }