From 46aaa02274a51ebe2aaa9fca2422dcebf9323475 Mon Sep 17 00:00:00 2001 From: Sunny Luo Date: Mon, 28 Jan 2019 08:18:42 -0800 Subject: [PATCH] Make the load-script-error less misleading (#17055) Summary: For most cases, people saw this error when they are running a debug version. So they should check metro server first. However, they were misled to search for "bundle" keywords and finally they executed "react-native bundle" command and got an app that can never reload. Pull Request resolved: https://github.com/facebook/react-native/pull/17055 Differential Revision: D13421737 Pulled By: cpojer fbshipit-source-id: 8e108df06b7d416a74c33581457f3213b28306c1 --- ReactAndroid/src/main/jni/react/jni/JSLoader.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/jni/react/jni/JSLoader.cpp b/ReactAndroid/src/main/jni/react/jni/JSLoader.cpp index 6e6898160..8f18dbc7f 100644 --- a/ReactAndroid/src/main/jni/react/jni/JSLoader.cpp +++ b/ReactAndroid/src/main/jni/react/jni/JSLoader.cpp @@ -59,8 +59,9 @@ std::unique_ptr loadScriptFromAssets( } } - throw std::runtime_error(folly::to("Unable to load script from assets '", assetName, - "'. Make sure your bundle is packaged correctly or you're running a packager server.")); + throw std::runtime_error(folly::to("Unable to load script. Make sure you're " + "either running a Metro server (run 'react-native start') or that your bundle '", assetName, + "' is packaged correctly for release.")); } }}