From 424d4458d72dcd746fb4c73b48f07e101fb1fa2f Mon Sep 17 00:00:00 2001 From: Marc Horowitz Date: Tue, 4 Dec 2018 11:42:24 -0800 Subject: [PATCH] Delete dead code Summary: It was made dead by the previous revisions Reviewed By: amnn Differential Revision: D13313263 fbshipit-source-id: b8c8402b5427dc5d3efbbd2ee871aebf1e14ee0d --- .../jsiexecutor/jsireact/JSIExecutor.cpp | 19 ------------------- .../jsiexecutor/jsireact/JSIExecutor.h | 17 ----------------- 2 files changed, 36 deletions(-) diff --git a/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp b/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp index 1178b4785..dbb9560ca 100644 --- a/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp +++ b/ReactCommon/jsiexecutor/jsireact/JSIExecutor.cpp @@ -21,25 +21,6 @@ using namespace facebook::jsi; namespace facebook { namespace react { -JSIExecutorFactory::JSIExecutorFactory( - std::shared_ptr runtime, - JSIExecutor::Logger logger, - JSIExecutor::RuntimeInstaller runtimeInstaller) - : runtime_(runtime), - logger_(logger), - runtimeInstaller_(runtimeInstaller) {} - -std::unique_ptr JSIExecutorFactory::createJSExecutor( - std::shared_ptr delegate, - std::shared_ptr) { - return std::make_unique( - runtime_, - delegate, - logger_, - JSIExecutor::defaultTimeoutInvoker, - runtimeInstaller_); -} - class JSIExecutor::NativeModuleProxy : public jsi::HostObject { public: NativeModuleProxy(JSIExecutor& executor) : executor_(executor) {} diff --git a/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h b/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h index af9d103dd..27d3b7dce 100644 --- a/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h +++ b/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h @@ -131,22 +131,5 @@ class JSIExecutor : public JSExecutor { folly::Optional callFunctionReturnResultAndFlushedQueue_; }; -class JSIExecutorFactory : public JSExecutorFactory { - public: - explicit JSIExecutorFactory( - std::shared_ptr runtime, - JSIExecutor::Logger logger, - JSIExecutor::RuntimeInstaller); - - std::unique_ptr createJSExecutor( - std::shared_ptr delegate, - std::shared_ptr jsQueue) override; - - private: - std::shared_ptr runtime_; - JSIExecutor::Logger logger_; - JSIExecutor::RuntimeInstaller runtimeInstaller_; -}; - } // namespace react } // namespace facebook