Misc. cleanup

This commit is contained in:
Alexsander Akers
2015-03-26 16:46:13 +00:00
parent 8bed1ef732
commit 415d756f5c
8 changed files with 4 additions and 29 deletions

View File

@@ -612,7 +612,6 @@ static id<RCTJavaScriptExecutor> _latestJSExecutor;
// Wait for queued methods to finish
dispatch_sync(self.shadowQueue, ^{
// Make sure all dispatchers have been executed before continuing
// TODO: is this still needed?
});
// Invalidate modules

View File

@@ -9,10 +9,8 @@
#import <Foundation/Foundation.h>
// TODO (#5906496): is there a reason for this protocol? It seems to be
// used in a number of places where it isn't really required - only the
// RCTBridge actually ever calls casts to it - in all other
// cases it is simply a way of adding some method definitions to classes
// TODO (#5906496): This protocol is only used to add method definitions to
// classes. We should decide if it's actually necessary.
@protocol RCTInvalidating <NSObject>

View File

@@ -34,7 +34,7 @@ static inline NSString *_RCTLogPreamble(const char *file, int lineNumber, const
return [NSString stringWithFormat:@"[RCTLog][tid:%@][%@:%d]>", threadName, fileName, lineNumber];
}
// TODO (#5906496): // kinda ugly that this is tied to RCTBridge
// TODO (#5906496): Does this need to be tied to RCTBridge?
NSString *RCTLogObjects(NSArray *objects, NSString *level)
{
NSString *str = objects[0];

View File

@@ -109,7 +109,7 @@ static NSError *RCTNSErrorFromJSError(JSContextRef context, JSValueRef jsError)
// run the run loop
while (kCFRunLoopRunStopped != CFRunLoopRunInMode(kCFRunLoopDefaultMode, [[NSDate distantFuture] timeIntervalSinceReferenceDate], NO)) {
RCTAssert(NO, @"not reached assertion"); // runloop spun. that's bad.
RCTAssert(NO, @"not reached assertion"); // runloop spun. that's bad.
}
}
}

View File

@@ -1356,10 +1356,6 @@ static void RCTMeasureLayout(RCTShadowView *view,
}];
}
// TODO: remove horrible hack - this is only here so that
// [rootView endAndResetInteractionTiming] below doesn't raise warnings
- (NSDictionary *)endAndResetInteractionTiming { return nil; }
- (void)endAndResetInteractionTiming:(RCTResponseSenderBlock)onSuccess
onError:(RCTResponseSenderBlock)onError
{