From 3fff811c5717a18038e451cd1534e522331769a8 Mon Sep 17 00:00:00 2001 From: Emil Sjolander Date: Fri, 28 Oct 2016 11:31:48 -0700 Subject: [PATCH] call super instead of self Summary: Call super.setPadding. Calling the overriden version will cause stack overflow. Differential Revision: D4096141 --- .../com/facebook/react/flat/FlatARTSurfaceViewShadowNode.java | 2 +- .../java/com/facebook/react/flat/FlatReactModalShadowNode.java | 2 +- .../main/java/com/facebook/react/flat/NativeViewWrapper.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatARTSurfaceViewShadowNode.java b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatARTSurfaceViewShadowNode.java index 81476487b..5f997352b 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatARTSurfaceViewShadowNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatARTSurfaceViewShadowNode.java @@ -104,7 +104,7 @@ import com.facebook.react.views.art.ARTVirtualNode; @Override public void setPadding(int spacingType, float padding) { if (getPadding(spacingType) != padding) { - setPadding(spacingType, padding); + super.setPadding(spacingType, padding); mPaddingChanged = true; dirty(); } diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatReactModalShadowNode.java b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatReactModalShadowNode.java index a33abdd06..8fc6936a7 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatReactModalShadowNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatReactModalShadowNode.java @@ -87,7 +87,7 @@ class FlatReactModalShadowNode extends FlatShadowNode implements AndroidView { @Override public void setPadding(int spacingType, float padding) { if (getPadding(spacingType) != padding) { - setPadding(spacingType, padding); + super.setPadding(spacingType, padding); mPaddingChanged = true; dirty(); } diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/NativeViewWrapper.java b/ReactAndroid/src/main/java/com/facebook/react/flat/NativeViewWrapper.java index 4d944b64d..e57ae4ded 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/NativeViewWrapper.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/NativeViewWrapper.java @@ -103,7 +103,7 @@ import com.facebook.react.uimanager.ViewManager; @Override public void setPadding(int spacingType, float padding) { if (getPadding(spacingType) != padding) { - setPadding(spacingType, padding); + super.setPadding(spacingType, padding); mPaddingChanged = true; dirty(); }