From 3a92f2017fc2e51c2a915f0e535397cb3937d412 Mon Sep 17 00:00:00 2001 From: Krzysztof Magiera Date: Mon, 26 Oct 2015 14:21:12 -0700 Subject: [PATCH] Fix buggy behavior of setBackgroundColor in react View. Differential Revision: D2582549 fb-gh-sync-id: 8856eb27d46df37e201cd1169fcec3b5b68dac97 --- .../facebook/react/views/view/ReactViewGroup.java | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java b/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java index b583eeb39..6131f0051 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java @@ -118,18 +118,8 @@ public class ReactViewGroup extends ViewGroup implements @Override public void setBackgroundColor(int color) { - if (color == Color.TRANSPARENT) { - Drawable backgroundDrawble = getBackground(); - if (mReactBackgroundDrawable != null && (backgroundDrawble instanceof LayerDrawable)) { - // extract translucent background portion from layerdrawable - super.setBackground(null); - LayerDrawable layerDrawable = (LayerDrawable) backgroundDrawble; - super.setBackground(layerDrawable.getDrawable(1)); - } else if (backgroundDrawble instanceof ReactViewBackgroundDrawable) { - // mReactBackground is set for background - mReactBackgroundDrawable = null; - super.setBackground(null); - } + if (color == Color.TRANSPARENT && mReactBackgroundDrawable == null) { + // don't do anything, no need to allocate ReactBackgroundDrawable for transparent background } else { getOrCreateReactViewBackground().setColor(color); }