kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-06 09:31:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Implement TextNodeRegion

Browse Source 
Summary: NodeRegion is only able to describe a rectangular region for touch, which is not good enough for text, where we want to be able to assign different touch ids to individual words (and those can span more than one line and in general have non-rectangular structure). This diff adds TextNodeRegion which inserts additional markers into text Layout to allow individual words to have unique react tags.

Reviewed By: ahmedre

Differential Revision: D2757387
This commit is contained in:
Denis Koroskin
2015-12-17 13:52:12 -08:00
committed by Ahmed El-Helw
parent 85cdfcd1f7
commit 381bf1b76f
10 changed files with 143 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
ReactAndroid/src/main/java/com/facebook/react/flat/StateBuilder.java
View File

@@ -63,7 +63,7 @@ import com.facebook.react.uimanager.CatalystStylesDiffMap;
float top = node.getLayoutY();
float right = left + width;
float bottom = top + height;
updateNodeRegion(node, tag, left, top, right, bottom);
node.updateNodeRegion(left, top, right, bottom);
mViewsToUpdateBounds.add(node);
@@ -170,6 +170,13 @@ import com.facebook.react.uimanager.CatalystStylesDiffMap;
isAndroidView = true;
needsCustomLayoutForChildren = androidView.needsCustomLayoutForChildren();
} else if (node.isVirtualAnchor()) {
// If RCTText is mounted to View, virtual children will not receive any touch events
// because they don't get added to nodeRegions, so nodeRegions will be empty and
// FlatViewGroup.reactTagForTouch() will always return RCTText's id. To fix the issue,
// manually add nodeRegion so it will have exactly one NodeRegion, and virtual nodes will
// be able to receive touch events.
addNodeRegion(node.getNodeRegion());
}
collectStateRecursively(node, 0, 0, width, height, isAndroidView, needsCustomLayoutForChildren);
@@ -320,7 +327,7 @@ import com.facebook.react.uimanager.CatalystStylesDiffMap;
float right = left + width;
float bottom = top + height;
updateNodeRegion(node, tag, left, top, right, bottom);
node.updateNodeRegion(left, top, right, bottom);
if (node.mountsToView()) {
ensureBackingViewIsCreated(node, tag, null);