kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-29 04:35:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make RNTester build and pass again (#22468)

Browse Source 
Summary:
Detox was failing because of build errors due to the new xcode10 build system. These errors were fixed by RSNara in b7349f9857 but this callsite was missed.
Pull Request resolved: https://github.com/facebook/react-native/pull/22468

Reviewed By: RSNara

Differential Revision: D13287386

Pulled By: TheSavior

fbshipit-source-id: 8a2df9801c69d851eabe7074ffc12b29c03a636a
This commit is contained in:
Eli White
2018-11-30 18:27:42 -08:00
committed by Facebook Github Bot
parent 003dbaa3d3
commit 3749da1312
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
RNTester/e2e/config.json
View File

@@ -1,5 +1,5 @@
{ {
"setupTestFrameworkScriptFile" : "./__tests__/init.js", "setupTestFrameworkScriptFile" : "./test-init.js",
"testEnvironment": "node", "testEnvironment": "node",
"bail": true, "bail": true,
"verbose": true "verbose": true

2
RNTester/e2e/__tests__/init.js → RNTester/e2e/test-init.js
View File

@@ -8,7 +8,7 @@
/* eslint-env jasmine */ /* eslint-env jasmine */
const detox = require('detox'); const detox = require('detox');
const config = require('../../../package.json').detox; const config = require('../../package.json').detox;
const adapter = require('detox/runners/jest/adapter'); const adapter = require('detox/runners/jest/adapter');
jest.setTimeout(480000); jest.setTimeout(480000);

2
package.json
View File

@@ -237,7 +237,7 @@
"configurations": { "configurations": {
"ios.sim.release": { "ios.sim.release": {
"binaryPath": "RNTester/build/Build/Products/Release-iphonesimulator/RNTester.app/", "binaryPath": "RNTester/build/Build/Products/Release-iphonesimulator/RNTester.app/",
"build": "xcodebuild -project RNTester/RNTester.xcodeproj -scheme RNTester -configuration Release -sdk iphonesimulator -derivedDataPath RNTester/build -quiet", "build": "xcodebuild -project RNTester/RNTester.xcodeproj -scheme RNTester -configuration Release -sdk iphonesimulator -derivedDataPath RNTester/build -UseModernBuildSystem=NO -quiet",
"type": "ios.simulator", "type": "ios.simulator",
"name": "iPhone 8" "name": "iPhone 8"
} }