From 3749da13127cb7455d533cb2bc5f2cf37470c0c7 Mon Sep 17 00:00:00 2001 From: Eli White Date: Fri, 30 Nov 2018 18:27:42 -0800 Subject: [PATCH] Make RNTester build and pass again (#22468) Summary: Detox was failing because of build errors due to the new xcode10 build system. These errors were fixed by RSNara in https://github.com/facebook/react-native/commit/b7349f9857df331e4c618256158662ea1f819ed5 but this callsite was missed. Pull Request resolved: https://github.com/facebook/react-native/pull/22468 Reviewed By: RSNara Differential Revision: D13287386 Pulled By: TheSavior fbshipit-source-id: 8a2df9801c69d851eabe7074ffc12b29c03a636a --- RNTester/e2e/config.json | 2 +- RNTester/e2e/{__tests__/init.js => test-init.js} | 2 +- package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) rename RNTester/e2e/{__tests__/init.js => test-init.js} (92%) diff --git a/RNTester/e2e/config.json b/RNTester/e2e/config.json index 3e2fe55b3..1c8ffa442 100644 --- a/RNTester/e2e/config.json +++ b/RNTester/e2e/config.json @@ -1,5 +1,5 @@ { - "setupTestFrameworkScriptFile" : "./__tests__/init.js", + "setupTestFrameworkScriptFile" : "./test-init.js", "testEnvironment": "node", "bail": true, "verbose": true diff --git a/RNTester/e2e/__tests__/init.js b/RNTester/e2e/test-init.js similarity index 92% rename from RNTester/e2e/__tests__/init.js rename to RNTester/e2e/test-init.js index 96c2562ff..5c70397a5 100644 --- a/RNTester/e2e/__tests__/init.js +++ b/RNTester/e2e/test-init.js @@ -8,7 +8,7 @@ /* eslint-env jasmine */ const detox = require('detox'); -const config = require('../../../package.json').detox; +const config = require('../../package.json').detox; const adapter = require('detox/runners/jest/adapter'); jest.setTimeout(480000); diff --git a/package.json b/package.json index 2d33da14e..2888ebf45 100644 --- a/package.json +++ b/package.json @@ -237,7 +237,7 @@ "configurations": { "ios.sim.release": { "binaryPath": "RNTester/build/Build/Products/Release-iphonesimulator/RNTester.app/", - "build": "xcodebuild -project RNTester/RNTester.xcodeproj -scheme RNTester -configuration Release -sdk iphonesimulator -derivedDataPath RNTester/build -quiet", + "build": "xcodebuild -project RNTester/RNTester.xcodeproj -scheme RNTester -configuration Release -sdk iphonesimulator -derivedDataPath RNTester/build -UseModernBuildSystem=NO -quiet", "type": "ios.simulator", "name": "iPhone 8" }