From 3589dec58ead82a6db9cc1ca7eb0e26f1710e75b Mon Sep 17 00:00:00 2001 From: Aaron Chiu Date: Tue, 24 Jan 2017 16:06:56 -0800 Subject: [PATCH] remove extraneous method data Reviewed By: achen1 Differential Revision: D4454618 fbshipit-source-id: f3e68fa6e00e27e2ff7a2f20500092e1eeeb10a1 --- .../react/cxxbridge/JavaModuleWrapper.java | 38 ------------------- .../jni/xreact/jni/ModuleRegistryHolder.h | 6 --- 2 files changed, 44 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/cxxbridge/JavaModuleWrapper.java b/ReactAndroid/src/main/java/com/facebook/react/cxxbridge/JavaModuleWrapper.java index de474adee..f2b249f4f 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/cxxbridge/JavaModuleWrapper.java +++ b/ReactAndroid/src/main/java/com/facebook/react/cxxbridge/JavaModuleWrapper.java @@ -9,7 +9,6 @@ package com.facebook.react.cxxbridge; -import java.lang.reflect.Method; import java.util.ArrayList; import java.util.List; import java.util.Map; @@ -38,10 +37,6 @@ import static com.facebook.systrace.Systrace.TRACE_TAG_REACT_JAVA_BRIDGE; /* package */ class JavaModuleWrapper { @DoNotStrip public class MethodDescriptor { - @DoNotStrip - Method method; - @DoNotStrip - String signature; @DoNotStrip String name; @DoNotStrip @@ -87,39 +82,6 @@ import static com.facebook.systrace.Systrace.TRACE_TAG_REACT_JAVA_BRIDGE; return descs; } - @DoNotStrip - public List newGetMethodDescriptors() { - ArrayList descs = new ArrayList<>(); - - for (Map.Entry entry : - getModule().getMethods().entrySet()) { - MethodDescriptor md = new MethodDescriptor(); - md.name = entry.getKey(); - md.type = entry.getValue().getType(); - - BaseJavaModule.JavaMethod method = (BaseJavaModule.JavaMethod) entry.getValue(); - md.method = method.getMethod(); - md.signature = method.getSignature(); - - descs.add(md); - } - - for (Map.Entry entry : - getModule().getSyncHooks().entrySet()) { - MethodDescriptor md = new MethodDescriptor(); - md.name = entry.getKey(); - md.type = BaseJavaModule.METHOD_TYPE_SYNC; - - BaseJavaModule.SyncJavaHook method = (BaseJavaModule.SyncJavaHook) entry.getValue(); - md.method = method.getMethod(); - md.signature = method.getSignature(); - - descs.add(md); - } - - return descs; - } - // TODO mhorowitz: make this return NativeMap, which requires moving // NativeMap out of OnLoad. @DoNotStrip diff --git a/ReactAndroid/src/main/jni/xreact/jni/ModuleRegistryHolder.h b/ReactAndroid/src/main/jni/xreact/jni/ModuleRegistryHolder.h index 29ff1b62e..106ed3142 100644 --- a/ReactAndroid/src/main/jni/xreact/jni/ModuleRegistryHolder.h +++ b/ReactAndroid/src/main/jni/xreact/jni/ModuleRegistryHolder.h @@ -50,12 +50,6 @@ struct JavaModuleWrapper : jni::JavaClass { getClass()->getMethod::javaobject()>("getMethodDescriptors"); return getMethods(self()); } - - jni::local_ref::javaobject> newGetMethodDescriptors() { - static auto getMethods = - getClass()->getMethod::javaobject()>("newGetMethodDescriptors"); - return getMethods(self()); - } }; class ModuleRegistryHolder : public jni::HybridClass {