From 3182b608fc63a37e806484e6528cb3695acd7da9 Mon Sep 17 00:00:00 2001 From: leeight Date: Wed, 14 Sep 2016 13:41:29 -0700 Subject: [PATCH] Fix invalid package name and Remove unsupported prop in Image.android.js Summary: 1. `textfrescosupport` -> `text.frescosupport` 2. `defaultImageSrc`, `imageTag` and `progressHandlerRegistered` looks like never exists in `ReactImageManager.java` Closes https://github.com/facebook/react-native/pull/9885 Differential Revision: D3864980 fbshipit-source-id: 48a85563c60b6853c505177558520f5e48f4eb03 --- Libraries/Image/Image.android.js | 3 --- .../FrescoBasedReactTextInlineImageShadowNode.java | 2 +- .../frescosupport/FrescoBasedReactTextInlineImageSpan.java | 2 +- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/Libraries/Image/Image.android.js b/Libraries/Image/Image.android.js index 9b4ea4153..8e0f5e84f 100644 --- a/Libraries/Image/Image.android.js +++ b/Libraries/Image/Image.android.js @@ -336,9 +336,6 @@ var cfg = { nativeOnly: { src: true, loadingIndicatorSrc: true, - defaultImageSrc: true, - imageTag: true, - progressHandlerRegistered: true, shouldNotifyLoadEvents: true, }, }; diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageShadowNode.java b/ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageShadowNode.java index 21e6f2384..fe759f41f 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageShadowNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageShadowNode.java @@ -24,7 +24,7 @@ import com.facebook.react.bridge.ReadableArray; import com.facebook.react.uimanager.annotations.ReactProp; import com.facebook.react.views.text.ReactTextInlineImageShadowNode; import com.facebook.react.views.text.TextInlineImageSpan; -import com.facebook.react.views.textfrescosupport.FrescoBasedReactTextInlineImageSpan; +import com.facebook.react.views.text.frescosupport.FrescoBasedReactTextInlineImageSpan; /** * {@link CSSNode} that represents an inline image. Loading is done using Fresco. diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageSpan.java b/ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageSpan.java index 0c0c5c124..771fdcb74 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageSpan.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageSpan.java @@ -7,7 +7,7 @@ * of patent rights can be found in the PATENTS file in the same directory. */ -package com.facebook.react.views.textfrescosupport; +package com.facebook.react.views.text.frescosupport; import javax.annotation.Nullable;