From 3110a6704703dc6b5dbd7b2d8ad08045e6dc686a Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Tue, 6 Nov 2018 10:58:49 -0800 Subject: [PATCH] Fabric: Explicit clearing std::vector after moving from it Summary: Apparently, the standard does not guarantee that the vector is empty after moving from it. So, let's clear it explicitly instead of asserting the emptiness. Reviewed By: sahrens Differential Revision: D12837227 fbshipit-source-id: 85dff6848707f4204f4c79be173064547e83c63e --- ReactCommon/fabric/events/EventBeatBasedExecutor.cpp | 2 +- ReactCommon/fabric/events/EventQueue.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactCommon/fabric/events/EventBeatBasedExecutor.cpp b/ReactCommon/fabric/events/EventBeatBasedExecutor.cpp index d31f620de..2f09d0bb5 100644 --- a/ReactCommon/fabric/events/EventBeatBasedExecutor.cpp +++ b/ReactCommon/fabric/events/EventBeatBasedExecutor.cpp @@ -62,7 +62,7 @@ void EventBeatBasedExecutor::onBeat(bool success) const { } tasks = std::move(tasks_); - assert(tasks_.size() == 0); + tasks_.clear(); } for (const auto task : tasks) { diff --git a/ReactCommon/fabric/events/EventQueue.cpp b/ReactCommon/fabric/events/EventQueue.cpp index e34bfd925..56389d3ca 100644 --- a/ReactCommon/fabric/events/EventQueue.cpp +++ b/ReactCommon/fabric/events/EventQueue.cpp @@ -35,7 +35,7 @@ void EventQueue::onBeat() const { } queue = std::move(queue_); - assert(queue_.size() == 0); + queue_.clear(); } {