kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-29 12:45:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

[react-packager] Rename 'Package' to 'Bundle'

Browse Source 
Summary:
The word Package is overloaded, it may mean npm package, or may mean a collection of bundles. Neither is what we mean. We mean `bundle`.

This renames it and modernize some of the Bundler code.
This commit is contained in:
Amjad Masad
2015-08-12 11:47:02 -07:00
parent c483db1b88
commit 309326db2e
11 changed files with 702 additions and 689 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
packager/react-packager/src/Server/__tests__/Server-test.js vendored
View File

@@ -24,7 +24,7 @@ var Promise = require('promise');
describe('processRequest', function() {
var server;
var Packager;
var Bundler;
var FileWatcher;
var options = {
@@ -57,10 +57,10 @@ describe('processRequest', function() {
var triggerFileChange;
beforeEach(function() {
Packager = require('../../Packager');
Bundler = require('../../Bundler');
FileWatcher = require('../../FileWatcher');
Packager.prototype.package = jest.genMockFunction().mockImpl(function() {
Bundler.prototype.bundle = jest.genMockFunction().mockImpl(function() {
return Promise.resolve({
getSource: function() {
return 'this is the source';
@@ -81,7 +81,7 @@ describe('processRequest', function() {
return this;
};
Packager.prototype.invalidateFile = invalidatorFunc;
Bundler.prototype.invalidateFile = invalidatorFunc;
var Server = require('../');
server = new Server(options);
@@ -121,7 +121,7 @@ describe('processRequest', function() {
'index.ios.includeRequire.bundle'
).then(function(response) {
expect(response).toEqual('this is the source');
expect(Packager.prototype.package).toBeCalledWith(
expect(Bundler.prototype.bundle).toBeCalledWith(
'index.ios.js',
true,
'index.ios.includeRequire.map',
@@ -142,7 +142,7 @@ describe('processRequest', function() {
describe('file changes', function() {
pit('invalides files in package when file is updated', function() {
pit('invalides files in bundle when file is updated', function() {
return makeRequest(
requestHandler,
'mybundle.bundle?runModule=true'
@@ -153,9 +153,9 @@ describe('processRequest', function() {
});
});
pit('rebuilds the packages that contain a file when that file is changed', function() {
var packageFunc = jest.genMockFunction();
packageFunc
pit('rebuilds the bundles that contain a file when that file is changed', function() {
var bundleFunc = jest.genMockFunction();
bundleFunc
.mockReturnValueOnce(
Promise.resolve({
getSource: function() {
@@ -173,7 +173,7 @@ describe('processRequest', function() {
})
);
Packager.prototype.package = packageFunc;
Bundler.prototype.bundle = bundleFunc;
var Server = require('../../Server');
server = new Server(options);
@@ -184,13 +184,13 @@ describe('processRequest', function() {
return makeRequest(requestHandler, 'mybundle.bundle?runModule=true')
.then(function(response) {
expect(response).toEqual('this is the first source');
expect(packageFunc.mock.calls.length).toBe(1);
expect(bundleFunc.mock.calls.length).toBe(1);
triggerFileChange('all','path/file.js', options.projectRoots[0]);
jest.runAllTimers();
jest.runAllTimers();
})
.then(function() {
expect(packageFunc.mock.calls.length).toBe(2);
expect(bundleFunc.mock.calls.length).toBe(2);
return makeRequest(requestHandler, 'mybundle.bundle?runModule=true')
.then(function(response) {
expect(response).toEqual('this is the rebuilt source');
@@ -259,12 +259,12 @@ describe('processRequest', function() {
});
});
describe('buildPackage(options)', function() {
it('Calls the packager with the correct args', function() {
server.buildPackage({
describe('buildBundle(options)', function() {
it('Calls the bundler with the correct args', function() {
server.buildBundle({
entryFile: 'foo file'
});
expect(Packager.prototype.package).toBeCalledWith(
expect(Bundler.prototype.bundle).toBeCalledWith(
'foo file',
true,
undefined,
@@ -273,10 +273,10 @@ describe('processRequest', function() {
});
});
describe('buildPackageFromUrl(options)', function() {
it('Calls the packager with the correct args', function() {
server.buildPackageFromUrl('/path/to/foo.bundle?dev=false&runModule=false');
expect(Packager.prototype.package).toBeCalledWith(
describe('buildBundleFromUrl(options)', function() {
it('Calls the bundler with the correct args', function() {
server.buildBundleFromUrl('/path/to/foo.bundle?dev=false&runModule=false');
expect(Bundler.prototype.bundle).toBeCalledWith(
'path/to/foo.js',
false,
'/path/to/foo.map',