From 2b356590f8ada117490d796e9ae00eaf50bd729b Mon Sep 17 00:00:00 2001
From: David Vacca <dvacca@fb.com>
Date: Mon, 28 Jan 2019 19:41:29 -0800
Subject: [PATCH] Remove components out of Bindings

Summary: This diff removes the components dependencies out of the Fabric/jsi/jni project

Reviewed By: shergin

Differential Revision: D13734001

fbshipit-source-id: 65182bfa5ee9fcd526a9afc40bd9fd6f0b86c5a5
---
 .../src/main/java/com/facebook/react/fabric/jsi/jni/BUCK    | 6 ------
 .../main/java/com/facebook/react/fabric/jsi/jni/Binding.cpp | 1 +
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/jni/BUCK b/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/jni/BUCK
index b79c3b786..7cad90f13 100644
--- a/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/jni/BUCK
+++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/jni/BUCK
@@ -28,14 +28,8 @@ rn_xplat_cxx_library(
     deps = [
         react_native_xplat_target("config:config"),
         react_native_xplat_target("fabric/uimanager:uimanager"),
-        react_native_xplat_target("fabric/components/activityindicator:activityindicator"),
         react_native_xplat_target("fabric/components/scrollview:scrollview"),
-        react_native_xplat_target("fabric/components/image:image"),
-        react_native_xplat_target("fabric/components/text:text"),
         react_native_target("jni/react/jni:jni"),
-        "xplat//ReactNative/fabric/components/ReactPerformanceLogger:ReactPerformanceLogger",
-        "xplat//ReactNative/fabric/components/ShimmeringView:ShimmeringView",
-        "xplat//ReactNative/fabric/components/TemplateView:TemplateView",
         "xplat//fbsystrace:fbsystrace",
         "xplat//folly:molly",
         "xplat//jsi:JSIDynamic",
diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/jni/Binding.cpp b/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/jni/Binding.cpp
index 5229202f1..d972f9873 100644
--- a/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/jni/Binding.cpp
+++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/jni/Binding.cpp
@@ -120,6 +120,7 @@ void Binding::uninstallFabricUIManager() {
   javaUIManager_ = nullptr;
 }
 
+//TODO: this method will be removed when binding for components are code-gen
 local_ref<JString> getPlatformComponentName(const ShadowView &shadowView) {
   local_ref<JString> componentName;
   auto newViewProps = std::dynamic_pointer_cast<const ScrollViewProps>(shadowView.props);