From 26b2aa91b68d9daff1604c4822f9eceffe3ee47b Mon Sep 17 00:00:00 2001 From: Konstantin Raev Date: Thu, 10 Mar 2016 15:58:36 -0800 Subject: [PATCH] Removed eslint rule that checks modules Summary:Removed eslint rule that checks modules After we updated to ESLint 2.x, ESLint started complaining `'use strict' is unnecessary inside of modules strict`. This is correct behaviour because according to spec modules are strict. The problem is that our transforms don't transpile strict mode so we still need to have this pragma in all our code. I did not find a way to make eslint require "use strict" for ES6 modules: https://github.com/eslint/eslint/issues/2785 So I am removing this. What stops us from automatically adding strict mode with babel? Need your feedback, frantic martinbigio David said that you Martin looked into this. Closes https://github.com/facebook/react-native/pull/6403 Differential Revision: D3038039 Pulled By: martinbigio fb-gh-sync-id: b8a00c093768a318487dcb89e433859825a08b2c shipit-source-id: b8a00c093768a318487dcb89e433859825a08b2c --- .eslintrc | 5 ----- Examples/UIExplorer/UIExplorerList.android.js | 2 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.eslintrc b/.eslintrc index d707517a0..03c36ec66 100644 --- a/.eslintrc +++ b/.eslintrc @@ -147,11 +147,6 @@ "wrap-iife": 0, // require immediate function invocation to be wrapped in parentheses (off by default) "yoda": 1, // require or disallow Yoda conditions - // Strict Mode - // These rules relate to using strict mode. - - "strict": [2, "global"], // require or disallow the "use strict" pragma in the global scope (off by default in the node environment) - // Variables // These rules have to do with variable declarations. diff --git a/Examples/UIExplorer/UIExplorerList.android.js b/Examples/UIExplorer/UIExplorerList.android.js index 68be333e5..341dddc92 100644 --- a/Examples/UIExplorer/UIExplorerList.android.js +++ b/Examples/UIExplorer/UIExplorerList.android.js @@ -15,6 +15,8 @@ */ 'use strict'; +const React = require('react-native'); + export type UIExplorerExample = { key: string; module: React.Component;