kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-07 02:08:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add JSContextRef param to String constructor

Browse Source 
Reviewed By: bnham

Differential Revision: D4197300

fbshipit-source-id: 306ffc85e3ced24047b68499f7cdf5e2d31fc052
This commit is contained in:
Pieter De Baets
2016-11-18 06:25:29 -08:00
committed by Facebook Github Bot
parent b1c91606ff
commit 20514e3482
13 changed files with 75 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ReactCommon/cxxreact/tests/value.cpp
View File

@@ -12,7 +12,6 @@
#include <stdexcept>
using namespace facebook;
using namespace facebook::react;
#ifdef ANDROID
@@ -21,15 +20,14 @@ static void prepare() {
ALooper_prepare(0);
}
#else
static void prepare() {
}
static void prepare() {}
#endif
TEST(Value, Undefined) {
prepare();
JSGlobalContextRef ctx = JSGlobalContextCreateInGroup(nullptr, nullptr);
auto v = Value::makeUndefined(ctx);
auto s = String::adopt(JSValueToStringCopy(ctx, v, nullptr));
auto s = String::adopt(ctx, JSValueToStringCopy(ctx, v, nullptr));
EXPECT_EQ("undefined", s.str());
JSGlobalContextRelease(ctx);
}
@@ -37,7 +35,7 @@ TEST(Value, Undefined) {
TEST(Value, FromJSON) {
prepare();
JSGlobalContextRef ctx = JSGlobalContextCreateInGroup(nullptr, nullptr);
react::String s("{\"a\": 4}");
String s(ctx, "{\"a\": 4}");
Value v(Value::fromJSON(ctx, s));
EXPECT_TRUE(JSValueIsObject(ctx, v));
JSGlobalContextRelease(ctx);
@@ -46,7 +44,7 @@ TEST(Value, FromJSON) {
TEST(Value, ToJSONString) {
prepare();
JSGlobalContextRef ctx = JSGlobalContextCreateInGroup(nullptr, nullptr);
react::String s("{\"a\": 4}");
String s(ctx, "{\"a\": 4}");
Value v(Value::fromJSON(ctx, s));
folly::dynamic dyn = folly::parseJson(v.toJSONString());
ASSERT_NE(nullptr, dyn);