From 1cb34cb761ec254f2a0f87b747aadb64c16dc2e2 Mon Sep 17 00:00:00 2001 From: empyrical Date: Wed, 13 Feb 2019 18:50:47 -0800 Subject: [PATCH] Fabric/DebugStringConvertibleItem.h: Fix for MSVC (#23436) Summary: This pull request removes a constructor in `DebugStringConvertibleItem.h` that was causing this issue in MSVC: ``` DebugStringConvertibleItem.cpp(20): error C2600: 'facebook::react::DebugStringConvertibleItem::DebugStringConvertibleItem': cannot define a compiler-generated special member function (must be declared in the class first) ``` It was likely conflicting with the constructor that has default values for all of its arguments. [General] [Fixed] - Fixed `DebugStringConvertibleItem` compilation on MSVC Pull Request resolved: https://github.com/facebook/react-native/pull/23436 Reviewed By: shergin Differential Revision: D14067760 Pulled By: mdvacca fbshipit-source-id: 303cf9b3559932c3d06514a1f3a8739d0f6f9dc2 --- ReactCommon/fabric/debug/DebugStringConvertibleItem.h | 1 - 1 file changed, 1 deletion(-) diff --git a/ReactCommon/fabric/debug/DebugStringConvertibleItem.h b/ReactCommon/fabric/debug/DebugStringConvertibleItem.h index f4b60fae1..42ba1c6af 100644 --- a/ReactCommon/fabric/debug/DebugStringConvertibleItem.h +++ b/ReactCommon/fabric/debug/DebugStringConvertibleItem.h @@ -21,7 +21,6 @@ namespace react { // in custom implementations of `getDebugChildren` and `getDebugProps`. class DebugStringConvertibleItem : public DebugStringConvertible { public: - DebugStringConvertibleItem() = default; DebugStringConvertibleItem(const DebugStringConvertibleItem &item) = default; DebugStringConvertibleItem(