mirror of
https://github.com/zhigang1992/react-native.git
synced 2026-04-30 05:55:48 +08:00
Remove iOS platform check for running devtools
Summary: Currently, DevTools only work under ios (although this is undocumented!), because the JavaScriptEngine initialization process skips setupDevTools() on android. DevTools work fine with Android, as tested on 0.26, 0.27, and 0.28 using Nuclide's inspector. For reference, [the relevant issue on react-devtools](https://github.com/facebook/react-devtools/issues/229). Closes https://github.com/facebook/react-native/pull/8095 Reviewed By: javache Differential Revision: D3443980 Pulled By: andreicoman11 fbshipit-source-id: 3d7b2e83cf4158a1228d2e21510509ab63411a5d
This commit is contained in:
committed by
Facebook Github Bot
parent
35f5ce296b
commit
1c290d69c1
@@ -11,6 +11,7 @@ package com.facebook.react.tests;
|
||||
import java.util.Arrays;
|
||||
import java.util.List;
|
||||
|
||||
import com.facebook.react.testing.FakeWebSocketModule;
|
||||
import com.facebook.react.testing.ReactIntegrationTestCase;
|
||||
import com.facebook.react.testing.ReactTestHelper;
|
||||
import com.facebook.react.testing.StringRecordingModule;
|
||||
@@ -59,9 +60,9 @@ public class JSLocaleTest extends ReactIntegrationTestCase {
|
||||
mInstance = ReactTestHelper.catalystInstanceBuilder(this)
|
||||
.addNativeModule(mStringRecordingModule)
|
||||
.addNativeModule(mUIManager)
|
||||
.addNativeModule(new FakeWebSocketModule())
|
||||
.addJSModule(TestJSLocaleModule.class)
|
||||
.build();
|
||||
|
||||
}
|
||||
|
||||
public void testToUpper() {
|
||||
@@ -100,6 +101,4 @@ public class JSLocaleTest extends ReactIntegrationTestCase {
|
||||
assertEquals("γαζίες καὶ μυρτιὲς δὲν θὰ βρῶ πιὰ στὸ χρυσαφὶ ξέφωτο", answers[3]);
|
||||
assertEquals("chinese: 幓 厏吪吙 鈊釿閍 碞碠粻 曮禷", answers[4]);
|
||||
}
|
||||
|
||||
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user