From 1bc52267f504eb02c8744c380fa2de878b0ab79f Mon Sep 17 00:00:00 2001 From: Ziqi Chen Date: Thu, 26 Jul 2018 13:44:57 -0700 Subject: [PATCH] accessibilityTraits + accessibilityComponentType >> accessibilityRole + accessibilityStates 3/3 Summary: Previously, I created two props, `accessibilityRole` and `accessibilityStates` for view. These props were intended to be a cross-platform solution to replace `accessibilityComponentType` on Android and `accessibilityTraits` on iOS. In this stack, I ran a code mod to replace instances of the two old properties used in our codebase with the new ones. For this diff, I did a search for the few remaining uses of `accessibilityTraits` that was not caught by my script or the previous diff in the stack, and I manually changed them to `accessibilityRole` and `accessibilityStates`. Changes in this diff generally followed this pattern: Before: ``` function accessibilityTraits(props: Props): Array { const traits = ['button']; if (props.selected) { traits.push('selected'); } return traits; } { const states = []; if (!props.enabled) { states.push('disabled'); } if (props.checked) { states.push('selected'); } return states; } { Accessibility label example - + Accessibility traits example