kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-12 19:48:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Capture StackOverflowExceptions triggered when drawing a ReactViewGroup or ReactRootView

Browse Source 
Reviewed By: achen1

Differential Revision: D6653395

fbshipit-source-id: 849b1a2ed6ab9bc057414d451e97a673178c30dd
This commit is contained in:
David Vacca
2018-01-18 18:45:54 -08:00
committed by Facebook Github Bot
parent 877f1cde2e
commit 1aac962378
6 changed files with 105 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContext.java
View File

@@ -304,13 +304,13 @@ public class ReactContext extends ContextWrapper {
* {@link com.facebook.react.bridge.NativeModuleCallExceptionHandler} if one exists, rethrowing
* otherwise.
*/
public void handleException(RuntimeException e) {
public void handleException(Exception e) {
if (mCatalystInstance != null &&
!mCatalystInstance.isDestroyed() &&
mNativeModuleCallExceptionHandler != null) {
mNativeModuleCallExceptionHandler.handleException(e);
} else {
throw e;
throw new RuntimeException(e);
}
}