kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-02 09:21:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

move ReactInstanceManager.Builder out of ReactInstanceManager into it's own class ReactInstanceManagerBuilder

Browse Source 
Reviewed By: thechefchen

Differential Revision: D4451541

fbshipit-source-id: d9cbcb61b232e817a1f4ff7b067a8a4e0c17150a
This commit is contained in:
Aaron Chiu
2017-01-23 17:00:17 -08:00
committed by Facebook Github Bot
parent f9df72c803
commit 17c9939444
6 changed files with 245 additions and 228 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactAppTestActivity.java
View File

@@ -22,6 +22,7 @@ import android.widget.FrameLayout;
import com.facebook.infer.annotation.Assertions;
import com.facebook.react.ReactInstanceManager;
import com.facebook.react.ReactInstanceManagerBuilder;
import com.facebook.react.ReactRootView;
import com.facebook.react.bridge.ReactContext;
import com.facebook.react.common.LifecycleState;
@@ -149,7 +150,7 @@ public class ReactAppTestActivity extends FragmentActivity implements
final CountDownLatch currentLayoutEvent = mLayoutEvent = new CountDownLatch(1);
mBridgeIdleSignaler = new ReactBridgeIdleSignaler();
ReactInstanceManager.Builder builder =
ReactInstanceManagerBuilder builder =
ReactTestHelper.getReactTestFactory().getReactInstanceManagerBuilder()
.setApplication(getApplication())
.setBundleAssetName(bundleName)

4
ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactTestFactory.java
View File

@@ -10,7 +10,7 @@ package com.facebook.react.testing;
import android.content.Context;
import com.facebook.react.ReactInstanceManager;
import com.facebook.react.ReactInstanceManagerBuilder;
import com.facebook.react.bridge.CatalystInstance;
import com.facebook.react.bridge.NativeModule;
@@ -23,5 +23,5 @@ public interface ReactTestFactory {
}
ReactInstanceEasyBuilder getCatalystInstanceBuilder();
ReactInstanceManager.Builder getReactInstanceManagerBuilder();
ReactInstanceManagerBuilder getReactInstanceManagerBuilder();
}

3
ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactTestHelper.java
View File

@@ -22,6 +22,7 @@ import android.view.ViewGroup;
import com.facebook.react.EagerModuleProvider;
import com.facebook.react.ReactInstanceManager;
import com.facebook.react.ReactInstanceManagerBuilder;
import com.facebook.react.bridge.CatalystInstance;
import com.facebook.react.bridge.JavaScriptModuleRegistry;
import com.facebook.react.bridge.ModuleSpec;
@@ -103,7 +104,7 @@ public class ReactTestHelper {
}
@Override
public ReactInstanceManager.Builder getReactInstanceManagerBuilder() {
public ReactInstanceManagerBuilder getReactInstanceManagerBuilder() {
return ReactInstanceManager.builder();
}
}