kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-24 04:16:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove the need for allowTopLevelThis in transform-es2015-modules-commonjs

Browse Source 
Summary:
This make the transform behave closer to the standard for modules.

This removes the few places that a top level this was used to refer to the global space. It also clean up the usage of `GLOBAL` to use `global` instead as this is what is used everywhere else in the code base. We still define `GLOBAL` for compatibility with other modules.

**Test plan**
Clear the packager cache to make sure the transforms run again. (node ./local-cli/cli.js start --reset-cache).
Run the Movies example (UIExplorer is broken atm) and make sure there are no errors.
Closes https://github.com/facebook/react-native/pull/6255

Differential Revision: D3037227

Pulled By: mkonicek

fb-gh-sync-id: bcf1350ae7a6e92c77d3a87fc9d6e42eb93cb9b9
fbshipit-source-id: bcf1350ae7a6e92c77d3a87fc9d6e42eb93cb9b9
This commit is contained in:
Janic Duplessis
2016-04-29 16:14:55 -07:00
committed by Facebook Github Bot 9
parent 373537b281
commit 169cfb5a52
3 changed files with 17 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/Utilities/ErrorUtils.js
View File

@@ -8,9 +8,7 @@
*
* @providesModule ErrorUtils
*/
/* eslint-disable consistent-this, global-strict */
var GLOBAL = this;
/* eslint-disable strict */
/**
* The particular require runtime that we are using looks for a global
@@ -24,4 +22,4 @@ var GLOBAL = this;
* that use it aren't just using a global variable, so simply export the global
* variable here. ErrorUtils is originally defined in a file named error-guard.js.
*/
module.exports = GLOBAL.ErrorUtils;
module.exports = global.ErrorUtils;