diff --git a/ReactCommon/cxxreact/tests/BUCK b/ReactCommon/cxxreact/tests/BUCK index 389a909f1..24acdd3ad 100644 --- a/ReactCommon/cxxreact/tests/BUCK +++ b/ReactCommon/cxxreact/tests/BUCK @@ -1,4 +1,12 @@ -load("//ReactNative:DEFS.bzl", "ANDROID_JSC_DEPS", "APPLE_JSC_DEPS", "IS_OSS_BUILD", "react_native_xplat_target") +load( + "//ReactNative:DEFS.bzl", + "ANDROID_JSC_DEPS", + "APPLE", + "APPLE_JSC_DEPS", + "react_native_xplat_target", + "jni_instrumentation_test_lib", + "fb_xplat_cxx_test", +) TEST_SRCS = [ "RecoverableErrorTest.cpp", @@ -10,46 +18,41 @@ TEST_SRCS = [ "value.cpp", ] -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - load("@xplat//configurations/buck/android:jni_instrumentation_test.bzl", "jni_instrumentation_test_lib") - load("@xplat//configurations/buck:default_platform_defs.bzl", "APPLE") +jni_instrumentation_test_lib( + name = "tests", + srcs = TEST_SRCS, + class_under_test = "com/facebook/react/XplatBridgeTest", + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + ], + soname = "libxplat-bridge.so", + visibility = [ + "fbandroid//instrumentation_tests/...", + ], + deps = [ + "xplat//third-party/linker_lib:android", + "xplat//third-party/gmock:gtest", + react_native_xplat_target("cxxreact:bridge"), + ] + ANDROID_JSC_DEPS, +) - jni_instrumentation_test_lib( - name = "tests", - class_under_test = "com/facebook/react/XplatBridgeTest", - soname = "libxplat-bridge.so", - srcs = TEST_SRCS, - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - ], - deps = [ - "xplat//third-party/linker_lib:android", - "xplat//third-party/gmock:gtest", - react_native_xplat_target("cxxreact:bridge"), - ] + ANDROID_JSC_DEPS, - visibility = [ - "fbandroid//instrumentation_tests/...", - ], - ) - - fb_xplat_cxx_test( - name = "tests", - srcs = TEST_SRCS, - compiler_flags = [ - "-fexceptions", - "-frtti", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - react_native_xplat_target("cxxreact:bridge"), - react_native_xplat_target("jschelpers:jschelpers"), - ] + APPLE_JSC_DEPS, - visibility = [ - react_native_xplat_target("cxxreact/..."), - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = TEST_SRCS, + compiler_flags = [ + "-fexceptions", + "-frtti", + ], + platforms = APPLE, + visibility = [ + react_native_xplat_target("cxxreact/..."), + ], + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + react_native_xplat_target("cxxreact:bridge"), + react_native_xplat_target("jschelpers:jschelpers"), + ] + APPLE_JSC_DEPS, +) diff --git a/ReactCommon/fabric/activityindicator/BUCK b/ReactCommon/fabric/activityindicator/BUCK index 952cb7977..aa4cd53f6 100644 --- a/ReactCommon/fabric/activityindicator/BUCK +++ b/ReactCommon/fabric/activityindicator/BUCK @@ -1,13 +1,7 @@ -load("@xplat//tools/build_defs:glob_defs.bzl", "subdir_glob") load("//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags") -load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") +load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "subdir_glob", "fb_xplat_cxx_test", "get_apple_compiler_flags", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") -APPLE_COMPILER_FLAGS = [] - -if not IS_OSS_BUILD: - load("@xplat//configurations/buck/apple:flag_defs.bzl", "flags", "get_static_library_ios_flags") - - APPLE_COMPILER_FLAGS = flags.get_flag_value(get_static_library_ios_flags(), "compiler_flags") +APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( name = "activityindicator", @@ -56,24 +50,20 @@ rn_xplat_cxx_library( ], ) -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - - fb_xplat_cxx_test( - name = "tests", - srcs = glob(["tests/**/*.cpp"]), - headers = glob(["tests/**/*.h"]), - contacts = ["oncall+react_native@xmail.facebook.com"], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - ":activityindicator", - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = glob(["tests/**/*.cpp"]), + headers = glob(["tests/**/*.h"]), + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + "-Wall", + ], + platforms = APPLE, + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + ":activityindicator", + ], +) diff --git a/ReactCommon/fabric/attributedstring/BUCK b/ReactCommon/fabric/attributedstring/BUCK index 61b897ba9..0be5eb78c 100644 --- a/ReactCommon/fabric/attributedstring/BUCK +++ b/ReactCommon/fabric/attributedstring/BUCK @@ -1,13 +1,17 @@ -load("@xplat//tools/build_defs:glob_defs.bzl", "subdir_glob") load("//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags") -load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") +load( + "//ReactNative:DEFS.bzl", + "ANDROID", + "APPLE", + "get_apple_inspector_flags", + "react_native_xplat_target", + "get_apple_compiler_flags", + "subdir_glob", + "fb_xplat_cxx_test", + "rn_xplat_cxx_library", +) -APPLE_COMPILER_FLAGS = [] - -if not IS_OSS_BUILD: - load("@xplat//configurations/buck/apple:flag_defs.bzl", "flags", "get_static_library_ios_flags") - - APPLE_COMPILER_FLAGS = flags.get_flag_value(get_static_library_ios_flags(), "compiler_flags") +APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( name = "attributedstring", @@ -58,24 +62,21 @@ rn_xplat_cxx_library( ], ) -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - - fb_xplat_cxx_test( - name = "tests", - srcs = glob(["tests/**/*.cpp"]), - headers = glob(["tests/**/*.h"]), - contacts = ["oncall+react_native@xmail.facebook.com"], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - ":attributedstring", - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = glob(["tests/**/*.cpp"]), + headers = glob(["tests/**/*.h"]), + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + "-Wall", + ], + contacts = ["oncall+react_native@xmail.facebook.com"], + platforms = APPLE, + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + ":attributedstring", + ], +) diff --git a/ReactCommon/fabric/components/image/BUCK b/ReactCommon/fabric/components/image/BUCK index fccf34aeb..896bd5ff0 100644 --- a/ReactCommon/fabric/components/image/BUCK +++ b/ReactCommon/fabric/components/image/BUCK @@ -1,13 +1,17 @@ -load("@xplat//tools/build_defs:glob_defs.bzl", "subdir_glob") load("//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags") -load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") +load( + "//ReactNative:DEFS.bzl", + "ANDROID", + "APPLE", + "fb_xplat_cxx_test", + "get_apple_compiler_flags", + "get_apple_inspector_flags", + "react_native_xplat_target", + "rn_xplat_cxx_library", + "subdir_glob", +) -APPLE_COMPILER_FLAGS = [] - -if not IS_OSS_BUILD: - load("@xplat//configurations/buck/apple:flag_defs.bzl", "flags", "get_static_library_ios_flags") - - APPLE_COMPILER_FLAGS = flags.get_flag_value(get_static_library_ios_flags(), "compiler_flags") +APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( name = "image", @@ -58,24 +62,21 @@ rn_xplat_cxx_library( ], ) -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - - fb_xplat_cxx_test( - name = "tests", - srcs = glob(["tests/**/*.cpp"]), - headers = glob(["tests/**/*.h"]), - contacts = ["oncall+react_native@xmail.facebook.com"], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - ":image", - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = glob(["tests/**/*.cpp"]), + headers = glob(["tests/**/*.h"]), + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + "-Wall", + ], + contacts = ["oncall+react_native@xmail.facebook.com"], + platforms = APPLE, + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + ":image", + ], +) diff --git a/ReactCommon/fabric/components/switch/BUCK b/ReactCommon/fabric/components/switch/BUCK index b2a4f8c1d..3026a7061 100644 --- a/ReactCommon/fabric/components/switch/BUCK +++ b/ReactCommon/fabric/components/switch/BUCK @@ -1,13 +1,17 @@ -load("@xplat//tools/build_defs:glob_defs.bzl", "subdir_glob") load("//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags") -load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") +load( + "//ReactNative:DEFS.bzl", + "ANDROID", + "APPLE", + "get_apple_compiler_flags", + "subdir_glob", + "get_apple_inspector_flags", + "react_native_xplat_target", + "fb_xplat_cxx_test", + "rn_xplat_cxx_library", +) -APPLE_COMPILER_FLAGS = [] - -if not IS_OSS_BUILD: - load("@xplat//configurations/buck/apple:flag_defs.bzl", "flags", "get_static_library_ios_flags") - - APPLE_COMPILER_FLAGS = flags.get_flag_value(get_static_library_ios_flags(), "compiler_flags") +APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( name = "switch", @@ -56,24 +60,21 @@ rn_xplat_cxx_library( ], ) -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - - fb_xplat_cxx_test( - name = "tests", - srcs = glob(["tests/**/*.cpp"]), - headers = glob(["tests/**/*.h"]), - contacts = ["oncall+react_native@xmail.facebook.com"], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - ":switch", - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = glob(["tests/**/*.cpp"]), + headers = glob(["tests/**/*.h"]), + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + "-Wall", + ], + contacts = ["oncall+react_native@xmail.facebook.com"], + platforms = APPLE, + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + ":switch", + ], +) diff --git a/ReactCommon/fabric/core/BUCK b/ReactCommon/fabric/core/BUCK index f663ff359..112cb850e 100644 --- a/ReactCommon/fabric/core/BUCK +++ b/ReactCommon/fabric/core/BUCK @@ -1,13 +1,7 @@ -load("@xplat//tools/build_defs:glob_defs.bzl", "subdir_glob") load("//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags") -load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") +load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "subdir_glob", "fb_xplat_cxx_test", "get_apple_compiler_flags", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") -APPLE_COMPILER_FLAGS = [] - -if not IS_OSS_BUILD: - load("@xplat//configurations/buck/apple:flag_defs.bzl", "flags", "get_static_library_ios_flags") - - APPLE_COMPILER_FLAGS = flags.get_flag_value(get_static_library_ios_flags(), "compiler_flags") +APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( name = "core", @@ -62,24 +56,21 @@ rn_xplat_cxx_library( ], ) -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - - fb_xplat_cxx_test( - name = "tests", - srcs = glob(["tests/**/*.cpp"]), - headers = glob(["tests/**/*.h"]), - contacts = ["oncall+react_native@xmail.facebook.com"], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - ":core", - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = glob(["tests/**/*.cpp"]), + headers = glob(["tests/**/*.h"]), + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + "-Wall", + ], + contacts = ["oncall+react_native@xmail.facebook.com"], + platforms = APPLE, + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + ":core", + ], +) diff --git a/ReactCommon/fabric/debug/BUCK b/ReactCommon/fabric/debug/BUCK index c16bedf03..c17aa3d4a 100644 --- a/ReactCommon/fabric/debug/BUCK +++ b/ReactCommon/fabric/debug/BUCK @@ -1,13 +1,22 @@ -load("@xplat//tools/build_defs:glob_defs.bzl", "subdir_glob") -load("//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags") -load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") +load( + "//configurations/buck/apple:flag_defs.bzl", + "OBJC_ARC_PREPROCESSOR_FLAGS", + "get_application_ios_flags", + "get_debug_preprocessor_flags", +) +load( + "//ReactNative:DEFS.bzl", + "ANDROID", + "APPLE", + "fb_xplat_cxx_test", + "get_apple_compiler_flags", + "get_apple_inspector_flags", + "react_native_xplat_target", + "rn_xplat_cxx_library", + "subdir_glob", +) -APPLE_COMPILER_FLAGS = [] - -if not IS_OSS_BUILD: - load("@xplat//configurations/buck/apple:flag_defs.bzl", "flags", "get_static_library_ios_flags") - - APPLE_COMPILER_FLAGS = flags.get_flag_value(get_static_library_ios_flags(), "compiler_flags") +APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( name = "debug", @@ -54,24 +63,21 @@ rn_xplat_cxx_library( ], ) -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - - fb_xplat_cxx_test( - name = "tests", - srcs = glob(["tests/**/*.cpp"]), - headers = glob(["tests/**/*.h"]), - contacts = ["oncall+react_native@xmail.facebook.com"], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - ":debug", - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = glob(["tests/**/*.cpp"]), + headers = glob(["tests/**/*.h"]), + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + "-Wall", + ], + contacts = ["oncall+react_native@xmail.facebook.com"], + platforms = APPLE, + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + ":debug", + ], +) diff --git a/ReactCommon/fabric/graphics/BUCK b/ReactCommon/fabric/graphics/BUCK index 78061adc6..0f8a26ff3 100644 --- a/ReactCommon/fabric/graphics/BUCK +++ b/ReactCommon/fabric/graphics/BUCK @@ -1,13 +1,17 @@ -load("@xplat//tools/build_defs:glob_defs.bzl", "subdir_glob") load("//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags") -load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") +load( + "//ReactNative:DEFS.bzl", + "ANDROID", + "APPLE", + "fb_xplat_cxx_test", + "get_apple_compiler_flags", + "get_apple_inspector_flags", + "react_native_xplat_target", + "rn_xplat_cxx_library", + "subdir_glob", +) -APPLE_COMPILER_FLAGS = [] - -if not IS_OSS_BUILD: - load("@xplat//configurations/buck/apple:flag_defs.bzl", "flags", "get_static_library_ios_flags") - - APPLE_COMPILER_FLAGS = flags.get_flag_value(get_static_library_ios_flags(), "compiler_flags") +APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( name = "graphics", @@ -90,24 +94,21 @@ rn_xplat_cxx_library( ], ) -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - - fb_xplat_cxx_test( - name = "tests", - srcs = glob(["tests/**/*.cpp"]), - headers = glob(["tests/**/*.h"]), - contacts = ["oncall+react_native@xmail.facebook.com"], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - ":graphics", - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = glob(["tests/**/*.cpp"]), + headers = glob(["tests/**/*.h"]), + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + "-Wall", + ], + contacts = ["oncall+react_native@xmail.facebook.com"], + platforms = APPLE, + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + ":graphics", + ], +) diff --git a/ReactCommon/fabric/imagemanager/BUCK b/ReactCommon/fabric/imagemanager/BUCK index a42904ea4..a1f7b3059 100644 --- a/ReactCommon/fabric/imagemanager/BUCK +++ b/ReactCommon/fabric/imagemanager/BUCK @@ -1,13 +1,17 @@ -load("@xplat//tools/build_defs:glob_defs.bzl", "subdir_glob") load("//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags") -load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") +load( + "//ReactNative:DEFS.bzl", + "ANDROID", + "APPLE", + "get_apple_inspector_flags", + "get_apple_compiler_flags", + "react_native_xplat_target", + "rn_xplat_cxx_library", + "fb_xplat_cxx_test", + "subdir_glob", +) -APPLE_COMPILER_FLAGS = [] - -if not IS_OSS_BUILD: - load("@xplat//configurations/buck/apple:flag_defs.bzl", "flags", "get_static_library_ios_flags") - - APPLE_COMPILER_FLAGS = flags.get_flag_value(get_static_library_ios_flags(), "compiler_flags") +APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( name = "imagemanager", @@ -99,24 +103,21 @@ rn_xplat_cxx_library( ], ) -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - - fb_xplat_cxx_test( - name = "tests", - srcs = glob(["tests/**/*.cpp"]), - headers = glob(["tests/**/*.h"]), - contacts = ["oncall+react_native@xmail.facebook.com"], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - ":imagemanager", - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = glob(["tests/**/*.cpp"]), + headers = glob(["tests/**/*.h"]), + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + "-Wall", + ], + contacts = ["oncall+react_native@xmail.facebook.com"], + platforms = APPLE, + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + ":imagemanager", + ], +) diff --git a/ReactCommon/fabric/scrollview/BUCK b/ReactCommon/fabric/scrollview/BUCK index 1f20c6553..d7343182b 100644 --- a/ReactCommon/fabric/scrollview/BUCK +++ b/ReactCommon/fabric/scrollview/BUCK @@ -1,13 +1,17 @@ -load("@xplat//tools/build_defs:glob_defs.bzl", "subdir_glob") load("//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags") -load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") +load( + "//ReactNative:DEFS.bzl", + "ANDROID", + "APPLE", + "fb_xplat_cxx_test", + "get_apple_compiler_flags", + "get_apple_inspector_flags", + "react_native_xplat_target", + "rn_xplat_cxx_library", + "subdir_glob", +) -APPLE_COMPILER_FLAGS = [] - -if not IS_OSS_BUILD: - load("@xplat//configurations/buck/apple:flag_defs.bzl", "flags", "get_static_library_ios_flags") - - APPLE_COMPILER_FLAGS = flags.get_flag_value(get_static_library_ios_flags(), "compiler_flags") +APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( name = "scrollview", @@ -60,24 +64,21 @@ rn_xplat_cxx_library( ], ) -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - - fb_xplat_cxx_test( - name = "tests", - srcs = glob(["tests/**/*.cpp"]), - headers = glob(["tests/**/*.h"]), - contacts = ["oncall+react_native@xmail.facebook.com"], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - ":scrollview", - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = glob(["tests/**/*.cpp"]), + headers = glob(["tests/**/*.h"]), + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + "-Wall", + ], + contacts = ["oncall+react_native@xmail.facebook.com"], + platforms = APPLE, + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + ":scrollview", + ], +) diff --git a/ReactCommon/fabric/text/BUCK b/ReactCommon/fabric/text/BUCK index e8dc5e597..dd51a9b5b 100644 --- a/ReactCommon/fabric/text/BUCK +++ b/ReactCommon/fabric/text/BUCK @@ -1,13 +1,17 @@ -load("@xplat//tools/build_defs:glob_defs.bzl", "subdir_glob") load("//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags") -load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") +load( + "//ReactNative:DEFS.bzl", + "ANDROID", + "APPLE", + "fb_xplat_cxx_test", + "get_apple_compiler_flags", + "get_apple_inspector_flags", + "react_native_xplat_target", + "rn_xplat_cxx_library", + "subdir_glob", +) -APPLE_COMPILER_FLAGS = [] - -if not IS_OSS_BUILD: - load("@xplat//configurations/buck/apple:flag_defs.bzl", "flags", "get_static_library_ios_flags") - - APPLE_COMPILER_FLAGS = flags.get_flag_value(get_static_library_ios_flags(), "compiler_flags") +APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( name = "text", @@ -66,24 +70,21 @@ rn_xplat_cxx_library( ], ) -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - - fb_xplat_cxx_test( - name = "tests", - srcs = glob(["tests/**/*.cpp"]), - headers = glob(["tests/**/*.h"]), - contacts = ["oncall+react_native@xmail.facebook.com"], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - ":text", - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = glob(["tests/**/*.cpp"]), + headers = glob(["tests/**/*.h"]), + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + "-Wall", + ], + contacts = ["oncall+react_native@xmail.facebook.com"], + platforms = APPLE, + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + ":text", + ], +) diff --git a/ReactCommon/fabric/textlayoutmanager/BUCK b/ReactCommon/fabric/textlayoutmanager/BUCK index 3ea41084b..9fb4a464f 100644 --- a/ReactCommon/fabric/textlayoutmanager/BUCK +++ b/ReactCommon/fabric/textlayoutmanager/BUCK @@ -1,13 +1,17 @@ -load("@xplat//tools/build_defs:glob_defs.bzl", "subdir_glob") load("//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags") -load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") +load( + "//ReactNative:DEFS.bzl", + "ANDROID", + "APPLE", + "fb_xplat_cxx_test", + "get_apple_compiler_flags", + "get_apple_inspector_flags", + "react_native_xplat_target", + "rn_xplat_cxx_library", + "subdir_glob", +) -APPLE_COMPILER_FLAGS = [] - -if not IS_OSS_BUILD: - load("@xplat//configurations/buck/apple:flag_defs.bzl", "flags", "get_static_library_ios_flags") - - APPLE_COMPILER_FLAGS = flags.get_flag_value(get_static_library_ios_flags(), "compiler_flags") +APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( name = "textlayoutmanager", @@ -106,24 +110,21 @@ rn_xplat_cxx_library( ], ) -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - - fb_xplat_cxx_test( - name = "tests", - srcs = glob(["tests/**/*.cpp"]), - headers = glob(["tests/**/*.h"]), - contacts = ["oncall+react_native@xmail.facebook.com"], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - ":textlayoutmanager", - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = glob(["tests/**/*.cpp"]), + headers = glob(["tests/**/*.h"]), + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + "-Wall", + ], + contacts = ["oncall+react_native@xmail.facebook.com"], + platforms = APPLE, + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + ":textlayoutmanager", + ], +) diff --git a/ReactCommon/fabric/uimanager/BUCK b/ReactCommon/fabric/uimanager/BUCK index 1b091a563..c7bc58bc4 100644 --- a/ReactCommon/fabric/uimanager/BUCK +++ b/ReactCommon/fabric/uimanager/BUCK @@ -1,13 +1,17 @@ -load("@xplat//tools/build_defs:glob_defs.bzl", "subdir_glob") load("//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags") -load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") +load( + "//ReactNative:DEFS.bzl", + "ANDROID", + "APPLE", + "fb_xplat_cxx_test", + "get_apple_compiler_flags", + "get_apple_inspector_flags", + "react_native_xplat_target", + "rn_xplat_cxx_library", + "subdir_glob", +) -APPLE_COMPILER_FLAGS = [] - -if not IS_OSS_BUILD: - load("@xplat//configurations/buck/apple:flag_defs.bzl", "flags", "get_static_library_ios_flags") - - APPLE_COMPILER_FLAGS = flags.get_flag_value(get_static_library_ios_flags(), "compiler_flags") +APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( name = "uimanager", @@ -61,24 +65,21 @@ rn_xplat_cxx_library( ], ) -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - - fb_xplat_cxx_test( - name = "tests", - srcs = glob(["tests/**/*.cpp"]), - headers = glob(["tests/**/*.h"]), - contacts = ["oncall+react_native@xmail.facebook.com"], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - ":uimanager", - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = glob(["tests/**/*.cpp"]), + headers = glob(["tests/**/*.h"]), + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + "-Wall", + ], + contacts = ["oncall+react_native@xmail.facebook.com"], + platforms = APPLE, + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + ":uimanager", + ], +) diff --git a/ReactCommon/fabric/view/BUCK b/ReactCommon/fabric/view/BUCK index 42ea4a7a5..54dc9ef20 100644 --- a/ReactCommon/fabric/view/BUCK +++ b/ReactCommon/fabric/view/BUCK @@ -1,13 +1,17 @@ -load("@xplat//tools/build_defs:glob_defs.bzl", "subdir_glob") load("//configurations/buck/apple:flag_defs.bzl", "OBJC_ARC_PREPROCESSOR_FLAGS", "get_application_ios_flags", "get_debug_preprocessor_flags") -load("//ReactNative:DEFS.bzl", "ANDROID", "APPLE", "IS_OSS_BUILD", "get_apple_inspector_flags", "react_native_xplat_target", "rn_xplat_cxx_library") +load( + "//ReactNative:DEFS.bzl", + "ANDROID", + "APPLE", + "fb_xplat_cxx_test", + "get_apple_compiler_flags", + "get_apple_inspector_flags", + "react_native_xplat_target", + "rn_xplat_cxx_library", + "subdir_glob", +) -APPLE_COMPILER_FLAGS = [] - -if not IS_OSS_BUILD: - load("@xplat//configurations/buck/apple:flag_defs.bzl", "flags", "get_static_library_ios_flags") - - APPLE_COMPILER_FLAGS = flags.get_flag_value(get_static_library_ios_flags(), "compiler_flags") +APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( name = "view", @@ -62,24 +66,21 @@ rn_xplat_cxx_library( ], ) -if not IS_OSS_BUILD: - load("@xplat//build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test") - - fb_xplat_cxx_test( - name = "tests", - srcs = glob(["tests/**/*.cpp"]), - headers = glob(["tests/**/*.h"]), - contacts = ["oncall+react_native@xmail.facebook.com"], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], - platforms = APPLE, - deps = [ - "xplat//folly:molly", - "xplat//third-party/gmock:gtest", - ":view", - ], - ) +fb_xplat_cxx_test( + name = "tests", + srcs = glob(["tests/**/*.cpp"]), + headers = glob(["tests/**/*.h"]), + compiler_flags = [ + "-fexceptions", + "-frtti", + "-std=c++14", + "-Wall", + ], + contacts = ["oncall+react_native@xmail.facebook.com"], + platforms = APPLE, + deps = [ + "xplat//folly:molly", + "xplat//third-party/gmock:gtest", + ":view", + ], +) diff --git a/ReactNative/DEFS.bzl b/ReactNative/DEFS.bzl index 451675f28..1f50344f6 100644 --- a/ReactNative/DEFS.bzl +++ b/ReactNative/DEFS.bzl @@ -263,3 +263,11 @@ def _single_subdir_glob(dirpath, glob_pattern, exclude = None, prefix = None): def oss_cxx_library(**kwargs): cxx_library(**kwargs) + +def jni_instrumentation_test_lib(**kwargs): + """A noop stub for OSS build.""" + pass + +def fb_xplat_cxx_test(**kwargs): + """A noop stub for OSS build.""" + pass