kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-27 19:25:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: Calling UIManager's uninstall function asynchonously

Browse Source 
Summary:
Calling `uninstall` synchnously was a bad idea. Unfortunatelly, even if it illuminate possible race condition during uninstallation, sometimes it deadlock.
It's not clear for now how to solve both problems without introducting another layer of indirection between UIManager and JSI.

Reviewed By: mdvacca

Differential Revision: D10081500

fbshipit-source-id: 90d8120603929a8219a3e606d8b3527e297b13ce
This commit is contained in:
Valentin Shergin
2018-10-08 14:34:27 -07:00
committed by Facebook Github Bot
parent 5f4aa6ae42
commit 0f683bb5c1
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ReactCommon/fabric/uimanager/FabricUIManager.cpp
View File

@@ -106,11 +106,9 @@ FabricUIManager::~FabricUIManager() {
auto executor = std::shared_ptr<EventBeatBasedExecutor> {std::move(executor_)};
auto uninstaller = std::move(uninstaller_);
// We have to call this synchronously to postpose UIManager deallocation
// until it is fully uninstalled and JavaScript cannot access this anymore.
(*executor)([uninstaller, executor]() {
uninstaller();
}, EventBeatBasedExecutor::Mode::Synchronous);
});
}
void FabricUIManager::setComponentDescriptorRegistry(const SharedComponentDescriptorRegistry &componentDescriptorRegistry) {