kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-26 13:25:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

improve console logging

Browse Source 
Summary:
* Always log when PRINT_TO_CONSOLE true - o reason to also check DEV.
* Log when `clearExceptTimespans` is called.
* Type `PRINT_TO_CONSOLE: false` to prevent accidental commits setting it true.

Reviewed By: alexeylang

Differential Revision: D7816623

fbshipit-source-id: 47cf7e158133045e20b345139efb1a79e5e6553b
This commit is contained in:
Spencer Ahrens
2018-04-30 11:41:14 -07:00
committed by Facebook Github Bot
parent 5b923e0eaf
commit 0f6762ba50
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
Libraries/Utilities/PerformanceLogger.js
View File

@@ -29,7 +29,7 @@ let timespans: {[key: string]: Timespan} = {};
let extras: {[key: string]: any} = {};
const cookies: {[key: string]: number} = {};
const PRINT_TO_CONSOLE = false;
const PRINT_TO_CONSOLE: false = false; // Type as false to prevent accidentally committing `true`;
/**
* This is meant to collect and log performance data in production, which means
@@ -69,7 +69,7 @@ const PerformanceLogger = {
startTime: performanceNow(),
};
cookies[key] = Systrace.beginAsyncEvent(key);
if (__DEV__ && PRINT_TO_CONSOLE) {
if (PRINT_TO_CONSOLE) {
infoLog('PerformanceLogger.js', 'start: ' + key);
}
},
@@ -97,7 +97,7 @@ const PerformanceLogger = {
timespan.endTime = performanceNow();
timespan.totalTime = timespan.endTime - (timespan.startTime || 0);
if (__DEV__ && PRINT_TO_CONSOLE) {
if (PRINT_TO_CONSOLE) {
infoLog('PerformanceLogger.js', 'end: ' + key);
}
@@ -108,7 +108,7 @@ const PerformanceLogger = {
clear() {
timespans = {};
extras = {};
if (__DEV__ && PRINT_TO_CONSOLE) {
if (PRINT_TO_CONSOLE) {
infoLog('PerformanceLogger.js', 'clear');
}
},
@@ -120,7 +120,7 @@ const PerformanceLogger = {
}
}
extras = {};
if (__DEV__ && PRINT_TO_CONSOLE) {
if (PRINT_TO_CONSOLE) {
infoLog('PerformanceLogger.js', 'clearCompleted');
}
},
@@ -133,6 +133,9 @@ const PerformanceLogger = {
return previous;
}, {});
extras = {};
if (PRINT_TO_CONSOLE) {
infoLog('PerformanceLogger.js', 'clearExceptTimespans', keys);
}
},
currentTimestamp() {