kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-24 04:16:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

check lifecycle event is coming from current activity

Browse Source 
Summary:
If a paused activity is destroyed (e.g. because of resource contention), we send onHostDestroyed to all modules even if there's an on-screen, resumed activity using the current react instance.

This diff adds a check to make sure lifecycle events come from the current activity, and ignores ones that don't.

Reviewed By: astreet

Differential Revision: D3655422

fbshipit-source-id: 0f95fda124df3732447853b9bc34c40836a4b1da
This commit is contained in:
Felix Oghina
2016-08-08 09:01:16 -07:00
committed by Facebook Github Bot 1
parent 46dc46a3b3
commit 0b5c61250b
3 changed files with 66 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
ReactAndroid/src/main/java/com/facebook/react/bridge/LifecycleEventListener.java
View File

@@ -10,23 +10,39 @@
package com.facebook.react.bridge;
/**
* Listener for receiving activity/service lifecycle events.
* Listener for receiving activity lifecycle events.
*
* When multiple activities share a react instance, only the most recent one's lifecycle events get
* forwarded to listeners. Consider the following scenarios:
*
* 1. Navigating from Activity A to B will trigger two events: A#onHostPause and B#onHostResume. Any
* subsequent lifecycle events coming from Activity A, such as onHostDestroy, will be ignored.
* 2. Navigating back from Activity B to Activity A will trigger the same events: B#onHostPause and
* A#onHostResume. Any subsequent events coming from Activity B, such as onHostDestroy, are
* ignored.
* 3. Navigating back from Activity A to a non-React Activity or to the home screen will trigger two
* events: onHostPause and onHostDestroy.
* 4. Navigating from Activity A to a non-React Activity B will trigger one event: onHostPause.
* Later, if Activity A is destroyed (e.g. because of resource contention), onHostDestroy is
* triggered.
*/
public interface LifecycleEventListener {
/**
* Called when host (activity/service) receives resume event (e.g. {@link Activity#onResume}
* Called when host activity receives resume event (e.g. {@link Activity#onResume}. Always called
* for the most current activity.
*/
void onHostResume();
/**
* Called when host (activity/service) receives pause event (e.g. {@link Activity#onPause}
* Called when host activity receives pause event (e.g. {@link Activity#onPause}. Always called
* for the most current activity.
*/
void onHostPause();
/**
* Called when host (activity/service) receives destroy event (e.g. {@link Activity#onDestroy}
* Called when host activity receives destroy event (e.g. {@link Activity#onDestroy}. Only called
* for the last React activity to be destroyed.
*/
void onHostDestroy();
}