From 0abaaeead0264ab51779045b1466625a7d7cf797 Mon Sep 17 00:00:00 2001 From: Andrei Coman Date: Mon, 26 Sep 2016 03:47:06 -0700 Subject: [PATCH] Modal: move style to xml Summary: The styles that get applied to the Dialogs that are created in RN are set in `themes.xml`, so I'm moving `windowTranslucentStatus` there as well so that we have all of them collocated. Reviewed By: astreet Differential Revision: D3913402 fbshipit-source-id: 8f23e84fb017c8810634ffe8279171061292b351 --- .../java/com/facebook/react/views/modal/ReactModalHostView.java | 2 -- ReactAndroid/src/main/res/views/modal/values/themes.xml | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostView.java b/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostView.java index e55840866..af6c7449e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostView.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostView.java @@ -247,8 +247,6 @@ public class ReactModalHostView extends ViewGroup implements LifecycleEventListe private void updateProperties() { Assertions.assertNotNull(mDialog, "mDialog must exist when we call updateProperties"); - mDialog.getWindow().addFlags(WindowManager.LayoutParams.FLAG_TRANSLUCENT_STATUS); - if (mTransparent) { mDialog.getWindow().clearFlags(WindowManager.LayoutParams.FLAG_DIM_BEHIND); } else { diff --git a/ReactAndroid/src/main/res/views/modal/values/themes.xml b/ReactAndroid/src/main/res/views/modal/values/themes.xml index 0efa67c76..e6f6a8902 100644 --- a/ReactAndroid/src/main/res/views/modal/values/themes.xml +++ b/ReactAndroid/src/main/res/views/modal/values/themes.xml @@ -6,6 +6,7 @@ true false @android:color/transparent + true