From 0a35529d5360eda2d8d10c7e633c4bc6c4b2bb27 Mon Sep 17 00:00:00 2001 From: Martin Konicek Date: Tue, 15 Mar 2016 12:15:35 -0700 Subject: [PATCH] Update PR guidelines Reviewed By: mkonicek Differential Revision:D3054232 Ninja: oss only fb-gh-sync-id: 6cb9b361f62c1bc009a412049b47be99c423d6e9 shipit-source-id: 6cb9b361f62c1bc009a412049b47be99c423d6e9 --- docs/PullRequestGuidelines.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/docs/PullRequestGuidelines.md b/docs/PullRequestGuidelines.md index d1b318ee8..682105916 100644 --- a/docs/PullRequestGuidelines.md +++ b/docs/PullRequestGuidelines.md @@ -1,13 +1,12 @@ ## Tips on reviewing pull requests -Does the PR miss info required in the [Pull request template](https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md)? Ask for it and link to the template. Add labels 'Needs revision' and 'Needs response from author'. Examples: [#6395](https://github.com/facebook/react-native/pull/6395). -Example: +Does the PR miss info required in the [Pull request template](https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md)? Example: [#6395](https://github.com/facebook/react-native/pull/6395). Add labels 'Needs revision' and 'Needs response from author'. Add a response like: > Hey @author, thanks for sending the pull request. > Can you please add all the info specified in the [template](https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md)? This is necessary for people to be able to understand and review your pull request. -Does the code style match the [Style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide), especially consistency with the rest of the codebase? If not, link to the style guide and add the label 'Needs revision'. +Does the code style match the [Style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide), especially consistency (formatting, naming) with the rest of the codebase? If not, link to the style guide and add the label 'Needs revision'. -Does the pull request add a completely new feature we don't want to add to the core and maintain? Ask the author to release it a separate npm module. +Does the pull request add a completely new feature we don't want to add to the core and maintain? Ask the author to release it a separate npm module and close the PR. Example: [#2648](https://github.com/facebook/react-native/pull/2648). -Does the pull request do several unrelated things at the same time? Ask the author to split it. +Does the pull request do several unrelated things at the same time? Ask the author to split it. \ No newline at end of file