From 042f254a12766ef06457003dac4e9db5134b14d9 Mon Sep 17 00:00:00 2001 From: Aaron Chiu Date: Mon, 24 Jul 2017 18:21:57 -0700 Subject: [PATCH] make member variables private instead of protected Reviewed By: sahrens Differential Revision: D5425194 fbshipit-source-id: 69c06a8e38bf3c4d84c2c426325e92abf63b4cb7 --- .../react/ReactInstanceManagerBuilder.java | 51 +++++++++---------- 1 file changed, 24 insertions(+), 27 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java index c2b3ecf71..e92d41985 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java @@ -2,14 +2,8 @@ package com.facebook.react; -import javax.annotation.Nullable; - -import java.util.ArrayList; -import java.util.List; - import android.app.Activity; import android.app.Application; - import com.facebook.infer.annotation.Assertions; import com.facebook.react.bridge.JSBundleLoader; import com.facebook.react.bridge.NativeModuleCallExceptionHandler; @@ -20,34 +14,37 @@ import com.facebook.react.devsupport.interfaces.DevBundleDownloadListener; import com.facebook.react.devsupport.interfaces.DevSupportManager; import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler; import com.facebook.react.uimanager.UIImplementationProvider; +import java.util.ArrayList; +import java.util.List; +import javax.annotation.Nullable; /** * Builder class for {@link ReactInstanceManager} */ public class ReactInstanceManagerBuilder { - protected final List mPackages = new ArrayList<>(); + private final List mPackages = new ArrayList<>(); - protected @Nullable String mJSBundleAssetUrl; - protected @Nullable JSBundleLoader mJSBundleLoader; - protected @Nullable String mJSMainModuleName; - protected @Nullable NotThreadSafeBridgeIdleDebugListener mBridgeIdleDebugListener; - protected @Nullable Application mApplication; - protected boolean mUseDeveloperSupport; - protected @Nullable LifecycleState mInitialLifecycleState; - protected @Nullable UIImplementationProvider mUIImplementationProvider; - protected @Nullable NativeModuleCallExceptionHandler mNativeModuleCallExceptionHandler; - protected JSCConfig mJSCConfig = JSCConfig.EMPTY; - protected @Nullable Activity mCurrentActivity; - protected @Nullable DefaultHardwareBackBtnHandler mDefaultHardwareBackBtnHandler; - protected @Nullable RedBoxHandler mRedBoxHandler; - protected boolean mLazyNativeModulesEnabled; - protected boolean mLazyViewManagersEnabled; - protected @Nullable DevBundleDownloadListener mDevBundleDownloadListener; - protected boolean mUseSeparateUIBackgroundThread; - protected int mMinNumShakes = 1; - protected boolean mEnableSplitPackage; - protected boolean mUseOnlyDefaultPackages; + private @Nullable String mJSBundleAssetUrl; + private @Nullable JSBundleLoader mJSBundleLoader; + private @Nullable String mJSMainModuleName; + private @Nullable NotThreadSafeBridgeIdleDebugListener mBridgeIdleDebugListener; + private @Nullable Application mApplication; + private boolean mUseDeveloperSupport; + private @Nullable LifecycleState mInitialLifecycleState; + private @Nullable UIImplementationProvider mUIImplementationProvider; + private @Nullable NativeModuleCallExceptionHandler mNativeModuleCallExceptionHandler; + private JSCConfig mJSCConfig = JSCConfig.EMPTY; + private @Nullable Activity mCurrentActivity; + private @Nullable DefaultHardwareBackBtnHandler mDefaultHardwareBackBtnHandler; + private @Nullable RedBoxHandler mRedBoxHandler; + private boolean mLazyNativeModulesEnabled; + private boolean mLazyViewManagersEnabled; + private @Nullable DevBundleDownloadListener mDevBundleDownloadListener; + private boolean mUseSeparateUIBackgroundThread; + private int mMinNumShakes = 1; + private boolean mEnableSplitPackage; + private boolean mUseOnlyDefaultPackages; /* package protected */ ReactInstanceManagerBuilder() { }