kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-04-10 22:47:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix for InterpolatorType crash

Browse Source 
Summary:
We're currently getting a redbox in Turkish when we try to convert the string 'easeInEaseOut' to an InterpolatorType. This is because I use toLowerCase() to compare the string without setting a locale; in Turkish, the capital letter 'I' doesn't convert to 'i' when you lowercase it, but rather to 'ı' (http://www.i18nguy.com/unicode/turkish-i18n.html).

Passing in a locale param to `toLowerCase()` fixes it. Also updating the test.

Differential Revision: D10315474

fbshipit-source-id: 54be3ff1d3f91cb2ec765ff705ac364b976b8c6f
This commit is contained in:
Emily Janzer
2018-10-10 15:29:45 -07:00
committed by Facebook Github Bot
parent a82f6e164b
commit 01a1004808
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ReactAndroid/src/main/java/com/facebook/react/uimanager/layoutanimation/InterpolatorType.java
View File

@@ -5,6 +5,8 @@
package com.facebook.react.uimanager.layoutanimation;
import java.util.Locale;
/**
* Enum representing the different interpolators that can be used in layout animation configuration.
*/
@@ -16,7 +18,7 @@ package com.facebook.react.uimanager.layoutanimation;
SPRING;
public static InterpolatorType fromString(String name) {
switch (name.toLowerCase()) {
switch (name.toLowerCase(Locale.US)) {
case "linear":
return LINEAR;
case "easein":