kylefang/react-native
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native.git synced 2026-05-10 01:15:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Cache Typefaces in shadow/flat/CustomStyleSpan

Browse Source 
Summary: @public `Typeface` handling in `shadow/flat/CustomStyleSpan` wasn't very efficient. This diff introduces `TypefaceCache` to avoid allocating duplicated `Typeface`s.

Reviewed By: sriramramani

Differential Revision: D2564363
This commit is contained in:
Denis Koroskin
2015-12-07 17:15:54 -08:00
committed by Ahmed El-Helw
parent 5c2f536e9a
commit 007318eb52
2 changed files with 80 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ReactAndroid/src/main/java/com/facebook/react/flat/FontStylingSpan.java
View File

@@ -84,14 +84,10 @@ import android.text.style.MetricAffectingSpan;
return;
}
// TODO: optimize this part (implemented in a followup patch)
if (mFontFamily != null) {
// efficient in API 21+
typeface = Typeface.create(mFontFamily, newStyle);
typeface = TypefaceCache.getTypeface(mFontFamily, newStyle);
} else {
// efficient in API 16+
typeface = Typeface.create(typeface, newStyle);
typeface = TypefaceCache.getTypeface(typeface, newStyle);
}
ds.setTypeface(typeface);