kylefang/react-native-web
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-web.git synced 2026-04-30 05:14:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

[change] remove 'resizeMode' static from 'Image'

Browse Source 
Use strings instead of the 'Image.resizeMode' static. Corresponding change in React Native:

https://github.com/facebook/react-native/commit/870775e
This commit is contained in:
Nicolas Gallagher
2018-11-12 13:06:23 -08:00
parent 2d1e303a6a
commit ead21b3aa2
4 changed files with 4 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/react-native-web/src/exports/Image/__tests__/__snapshots__/index-test.js.snap
View File

@@ -12,6 +12,8 @@ exports[`components/Image prop "resizeMode" value "cover" 1`] = `"cover"`;
exports[`components/Image prop "resizeMode" value "none" 1`] = `"auto"`; exports[`components/Image prop "resizeMode" value "none" 1`] = `"auto"`;
exports[`components/Image prop "resizeMode" value "repeat" 1`] = `"auto"`;
exports[`components/Image prop "resizeMode" value "stretch" 1`] = `"100% 100%"`; exports[`components/Image prop "resizeMode" value "stretch" 1`] = `"100% 100%"`;
exports[`components/Image prop "resizeMode" value "undefined" 1`] = `"cover"`; exports[`components/Image prop "resizeMode" value "undefined" 1`] = `"cover"`;

10
packages/react-native-web/src/exports/Image/__tests__/index-test.js vendored
View File

@@ -141,13 +141,7 @@ describe('components/Image', () => {
}); });
describe('prop "resizeMode"', () => { describe('prop "resizeMode"', () => {
[ ['contain', 'cover', 'none', 'repeat', 'stretch', undefined].forEach(resizeMode => {
Image.resizeMode.contain,
Image.resizeMode.cover,
Image.resizeMode.none,
Image.resizeMode.stretch,
undefined
].forEach(resizeMode => {
test(`value "${resizeMode}"`, () => { test(`value "${resizeMode}"`, () => {
const component = shallow(<Image resizeMode={resizeMode} />); const component = shallow(<Image resizeMode={resizeMode} />);
expect(findImageSurfaceStyle(component).backgroundSize).toMatchSnapshot(); expect(findImageSurfaceStyle(component).backgroundSize).toMatchSnapshot();
@@ -214,7 +208,7 @@ describe('components/Image', () => {
describe('prop "style"', () => { describe('prop "style"', () => {
test('supports "resizeMode" property', () => { test('supports "resizeMode" property', () => {
const component = shallow(<Image style={{ resizeMode: Image.resizeMode.contain }} />); const component = shallow(<Image style={{ resizeMode: 'contain' }} />);
expect(findImageSurfaceStyle(component).backgroundSize).toMatchSnapshot(); expect(findImageSurfaceStyle(component).backgroundSize).toMatchSnapshot();
}); });

2
packages/react-native-web/src/exports/Image/index.js vendored
View File

@@ -132,8 +132,6 @@ class Image extends Component<*, State> {
return ImageLoader.prefetch(uri); return ImageLoader.prefetch(uri);
} }
static resizeMode = ImageResizeMode;
_filterId = 0; _filterId = 0;
_imageRef = null; _imageRef = null;
_imageRequestId = null; _imageRequestId = null;

10
packages/website/storybook/1-components/Image/ImageScreen.js
View File

@@ -136,16 +136,6 @@ const ImageScreen = () => (
/> />
</Section> </Section>
<Section title="Properties">
<DocItem
name="static resizeMode"
typeInfo="object"
example={{
code: '<Image resizeMode={Image.resizeMode.contain} />'
}}
/>
</Section>
<Section title="Methods"> <Section title="Methods">
<DocItem <DocItem
name="static getSize" name="static getSize"