Move commons into /app (#2486)

* stash

* move commons into the app

packages/database/lib/DatabaseDataSnapshot.js

@@ -15,8 +15,8 @@
  *
  */
 
-import { isString, isArray, isFunction, isObject } from '@react-native-firebase/common';
-import { deepGet } from '@react-native-firebase/common/lib/deeps';
+import { isArray, isFunction, isObject, isString } from '@react-native-firebase/app/lib/common';
+import { deepGet } from '@react-native-firebase/app/lib/common/deeps';
 
 export default class DatabaseDataSnapshot {
   constructor(reference, snapshot) {

packages/database/lib/DatabaseOnDisconnect.js

@@ -21,10 +21,10 @@ import {
   isNumber,
   isObject,
   isString,
-  isValidPath,
   isUndefined,
+  isValidPath,
   promiseWithOptionalCallback,
-} from '@react-native-firebase/common';
+} from '@react-native-firebase/app/lib/common';
 
 export default class DatabaseOnDisconnect {
   constructor(reference) {

packages/database/lib/DatabaseQuery.js

@@ -26,7 +26,7 @@ import {
   pathIsEmpty,
   pathToUrlEncodedString,
   ReferenceBase,
-} from '@react-native-firebase/common';
+} from '@react-native-firebase/app/lib/common';
 import DatabaseDataSnapshot from './DatabaseDataSnapshot';
 import DatabaseSyncTree from './DatabaseSyncTree';
 

packages/database/lib/DatabaseQueryModifiers.js

@@ -15,7 +15,7 @@
  *
  */
 
-import { isNull, isNumber, isString } from '@react-native-firebase/common';
+import { isNull, isNumber, isString } from '@react-native-firebase/app/lib/common';
 
 const CONSTANTS = {
   VIEW_FROM_LEFT: 'left',

packages/database/lib/DatabaseReference.js

@@ -16,26 +16,25 @@
  */
 
 import {
-  isString,
-  pathParent,
-  pathChild,
-  isValidPath,
   generateDatabaseId,
-  isNumber,
-  isNull,
-  isUndefined,
-  isFunction,
-  promiseWithOptionalCallback,
-  isObject,
   isBoolean,
-} from '@react-native-firebase/common';
-
-import DatabaseQueryModifiers from './DatabaseQueryModifiers';
-import DatabaseOnDisconnect from './DatabaseOnDisconnect';
+  isFunction,
+  isNull,
+  isNumber,
+  isObject,
+  isString,
+  isUndefined,
+  isValidPath,
+  pathChild,
+  pathParent,
+  promiseWithOptionalCallback,
+} from '@react-native-firebase/app/lib/common';
 import DatabaseDataSnapshot from './DatabaseDataSnapshot';
+import DatabaseOnDisconnect from './DatabaseOnDisconnect';
 import DatabaseQuery, {
   provideReferenceClass as provideReferenceClassForQuery,
 } from './DatabaseQuery';
+import DatabaseQueryModifiers from './DatabaseQueryModifiers';
 import DatabaseThenableReference, {
   provideReferenceClass as provideReferenceClassForThenable,
 } from './DatabaseThenableReference';

packages/database/lib/DatabaseSyncTree.js

@@ -15,10 +15,10 @@
  *
  */
 
-import { NativeModules } from 'react-native';
+import { isString } from '@react-native-firebase/app/lib/common';
 import NativeError from '@react-native-firebase/app/lib/internal/NativeFirebaseError';
-import { isString } from '@react-native-firebase/common';
 import SharedEventEmitter from '@react-native-firebase/app/lib/internal/SharedEventEmitter';
+import { NativeModules } from 'react-native';
 import DatabaseDataSnapshot from './DatabaseDataSnapshot';
 
 class DatabaseSyncTree {
@@ -116,7 +116,7 @@ class DatabaseSyncTree {
    * @param registration
    * @return {null}
    */
-  getRegistration(registration: string) {
+  getRegistration(registration) {
     return this._reverseLookup[registration]
       ? Object.assign({}, this._reverseLookup[registration])
       : null;

packages/database/lib/index.js

@@ -15,17 +15,16 @@
  *
  */
 
+import { isBoolean, isNumber, isString } from '@react-native-firebase/app/lib/common';
 import {
   createModuleNamespace,
   FirebaseModule,
   getFirebaseRoot,
 } from '@react-native-firebase/app/lib/internal';
-import { isString, isBoolean, isNumber } from '@react-native-firebase/common';
-
-import version from './version';
-import DatabaseStatics from './DatabaseStatics';
 import DatabaseReference from './DatabaseReference';
+import DatabaseStatics from './DatabaseStatics';
 import DatabaseTransaction from './DatabaseTransaction';
+import version from './version';
 
 const namespace = 'database';