kylefang/react-native-firebase
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-firebase.git synced 2026-04-24 04:24:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(functions): throw UNAVAILABLE code on network IO errors (#3327)

Browse Source
This commit is contained in:
Justin Huntington
2020-04-03 09:20:53 -04:00
committed by GitHub
parent c7a02a1658
commit 73511472bd
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/functions/android/src/reactnative/java/io/invertase/firebase/functions/ReactNativeFirebaseFunctionsModule.java
View File

@@ -29,6 +29,8 @@ import com.google.firebase.functions.FirebaseFunctionsException;
import io.invertase.firebase.common.RCTConvertFirebase;
import io.invertase.firebase.common.ReactNativeFirebaseModule;
import java.io.IOException;
import static io.invertase.firebase.functions.UniversalFirebaseFunctionsModule.CODE_KEY;
import static io.invertase.firebase.functions.UniversalFirebaseFunctionsModule.DATA_KEY;
import static io.invertase.firebase.functions.UniversalFirebaseFunctionsModule.DETAILS_KEY;
@@ -76,6 +78,11 @@ public class ReactNativeFirebaseFunctionsModule extends ReactNativeFirebaseModul
details = functionsException.getDetails();
code = functionsException.getCode().name();
message = functionsException.getMessage();
if (functionsException.getCause() instanceof IOException) {
// return UNAVAILABLE for network io errors, to match iOS
code = FirebaseFunctionsException.Code.UNAVAILABLE.name();
message = FirebaseFunctionsException.Code.UNAVAILABLE.name();
}
}
RCTConvertFirebase.mapPutValue(CODE_KEY, code, userInfo);
RCTConvertFirebase.mapPutValue(MSG_KEY, message, userInfo);