kylefang/react-native-firebase
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-firebase.git synced 2026-06-19 18:23:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(analytics): ts logEvent params arg should be optional (#2822)

Browse Source 
* Fix analytics log event params not optional when it should be

* Update Flow analytics log event type not in sync
This commit is contained in:
Tom Berriot
2019-11-25 23:33:25 +01:00
committed by Mike Diarmid
parent 4c19b9439d
commit 3b8757c0d4
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/analytics/lib/index.d.ts vendored
View File

@@ -670,7 +670,7 @@ export namespace FirebaseAnalyticsTypes {
* @param name Event name must not conflict with any Reserved Events.
* @param params Parameters to be sent and displayed with the event.
*/
logEvent(name: string, params: { [key: string]: string | number | boolean }): Promise<void>;
logEvent(name: string, params?: { [key: string]: string | number | boolean } | {} ): Promise<void>;
/**
* If true, allows the device to collect analytical data and send it to

2
packages/analytics/lib/index.js.flow
View File

@@ -623,7 +623,7 @@ export interface Module extends ReactNativeFirebaseModule {
* @param name Event name must not conflict with any Reserved Events. 100 characters is the maximum length for param key names.
* @param params Parameters to be sent and displayed with the event.
*/
logEvent(name: string, params: { [key: string]: string }): Promise<void>;
logEvent(name: string, params?: { [key: string]: string | number | boolean } | {}): Promise<void>;
/**
* If true, allows the device to collect analytical data and send it to Firebase.