kylefang/react-native-firebase
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-firebase.git synced 2026-04-26 13:34:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

[firestore] remove unnecessary intern fn _offDocumentSnapshot -> EE already returns a subscription instance with a remove();

Browse Source 
[firestore] additionally refactor unsubscribe so it can be called if an error is received on subscribing
This commit is contained in:
Salakar
2018-09-20 18:13:07 +01:00
parent 0e72881bff
commit 3ac9311eaa
2 changed files with 29 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/e2e/firestore/documentReference.e2e.js
View File

@@ -2,6 +2,7 @@ const {
test2DocRef,
COL2_DOC_1,
COL2_DOC_1_ID,
cleanCollection,
COL2_DOC_1_PATH,
TEST_COLLECTION_NAME_DYNAMIC,
resetTestCollectionDoc,
@@ -126,6 +127,12 @@ describe('firestore()', () => {
});
describe('onSnapshot()', () => {
beforeEach(async () => {
await sleep(50);
await cleanCollection(TEST_COLLECTION_NAME_DYNAMIC);
await sleep(50);
});
it('calls callback with the initial data and then when value changes', async () => {
await resetTestCollectionDoc(COL2_DOC_1_PATH, { name: 'doc1' });
const docRef = test2DocRef(COL2_DOC_1_ID);