From 377f34247798216d7ce8fee23ea541c2a908bcb2 Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Mon, 10 Aug 2020 12:33:27 -0500 Subject: [PATCH] fix(android,iid): workaround IID version missing in BOM w/concrete version IID will fail if included / used directly (instead of as transitive dependency) because they stopped publishing the IID version in the BoM This is being tracked upstream and I put breadcrumbs in the code that should help maintainers during version bumps --- packages/iid/android/build.gradle | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/iid/android/build.gradle b/packages/iid/android/build.gradle index 4964c976..f1461052 100644 --- a/packages/iid/android/build.gradle +++ b/packages/iid/android/build.gradle @@ -30,7 +30,7 @@ if (findProject(':@react-native-firebase_app')) { } def packageJson = PackageJson.getForProject(project) def appPackageJson = PackageJson.getForProject(appProject) -def firebaseBomVersion = appPackageJson['sdkVersions'] ? appPackageJson['sdkVersions']['android']['firebase'] : "25.5.0" +def firebaseBomVersion = appPackageJson['sdkVersions'] ? appPackageJson['sdkVersions']['android']['firebase'] : "25.5.0" // ALIGN CONCRETE VERSION BELOW WHEN CHANGING THIS def coreVersionDetected = appPackageJson['version'] def coreVersionRequired = packageJson['peerDependencies'][appPackageJson['name']] // Only log after build completed so log warning appears at the end @@ -87,7 +87,11 @@ repositories { dependencies { api appProject implementation platform("com.google.firebase:firebase-bom:${ReactNative.ext.getVersion("firebase", "bom")}") - implementation "com.google.firebase:firebase-iid" + // TODO Must put the concrete version here as the BoM no longer publishes the IID version, align it with the BoM change above + // Upstream issue: https://github.com/firebase/firebase-android-sdk/issues/1077 + // Issue: https://github.com/invertase/react-native-firebase/issues/3918 + // Example of where to find concrete version to match BoM: https://firebase.google.com/support/release-notes/android#iid_v20-2-1 + implementation "com.google.firebase:firebase-iid:20.2.1" // NEED CONCRETE VERSION HERE TO MATCH BOM RELEASE } ReactNative.shared.applyPackageVersion()