kylefang/react-native-firebase
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-firebase.git synced 2026-04-23 20:10:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat!: all packages should depend on core (#3613)

Browse Source 
All packages now peer-depend on an explicit version of the `app` package.

BREAKING CHANGE: breaking change to mark new internal versioning requirements.
This commit is contained in:
Mike Diarmid
2020-05-05 20:25:08 +01:00
committed by GitHub
parent 4b75d550ea
commit 252a4239e9
52 changed files with 659 additions and 212 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
packages/messaging/android/build.gradle
View File

@@ -1,3 +1,5 @@
import io.invertase.gradle.common.PackageJson
buildscript {
// The Android Gradle plugin is only required when opening the android folder stand-alone.
// This avoids unnecessary downloads and potential conflicts when the library is included as a
@@ -18,6 +20,27 @@ plugins {
id "io.invertase.gradle.build" version "1.4"
}
def appProject
if (findProject(':@react-native-firebase_app')) {
appProject = project(':@react-native-firebase_app')
} else if (findProject(':react-native-firebase_app')) {
appProject = project(':react-native-firebase_app')
} else {
throw new GradleException('Could not find the react-native-firebase/app package, have you installed it?')
}
def packageJson = PackageJson.getForProject(project)
def appPackageJson = PackageJson.getForProject(appProject)
def firebaseBomVersion = appPackageJson['sdkVersions'] ? appPackageJson['sdkVersions']['android']['firebase'] : "24.1.0"
def coreVersionDetected = appPackageJson['version']
def coreVersionRequired = packageJson['peerDependencies'][appPackageJson['name']]
// Only log after build completed so log warning appears at the end
if (coreVersionDetected != coreVersionRequired) {
gradle.buildFinished {
project.logger.warn("ReactNativeFirebase WARNING: NPM package '${packageJson['name']}' depends on '${appPackageJson['name']}' v${coreVersionRequired} but found v${coreVersionDetected}, this might cause build issues or runtime crashes.")
}
}
project.ext {
set('react-native', [
versions: [
@@ -31,7 +54,7 @@ project.ext {
],
firebase: [
bom: "24.1.0",
bom: firebaseBomVersion,
],
],
])
@@ -78,13 +101,7 @@ repositories {
}
dependencies {
if (findProject(':@react-native-firebase_app')) {
api project(':@react-native-firebase_app')
} else if (findProject(':react-native-firebase_app')) {
api project(':react-native-firebase_app')
} else {
throw new GradleException('Could not find the react-native-firebase/app package, have you installed it?')
}
api appProject
implementation platform("com.google.firebase:firebase-bom:${ReactNative.ext.getVersion("firebase", "bom")}")
implementation "com.google.firebase:firebase-messaging"
}