kylefang/react-native-firebase
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-firebase.git synced 2026-04-20 07:44:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Performance bug (#3123)

Browse Source 
* floating point number bug fix

* formatting
This commit is contained in:
Russell Wheatley
2020-01-27 10:11:56 +00:00
committed by GitHub
parent e8e7becc06
commit 1e567214e9
2 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/perf/android/src/main/java/io/invertase/firebase/perf/UniversalFirebasePerfModule.java
View File

@@ -117,15 +117,15 @@ public class UniversalFirebasePerfModule extends UniversalFirebaseModule {
HttpMetric httpMetric = httpMetrics.get(id);
if (httpMetricConfig.containsKey("httpResponseCode")) {
httpMetric.setHttpResponseCode(httpMetricConfig.getInt("httpResponseCode"));
httpMetric.setHttpResponseCode((int) httpMetricConfig.getDouble("httpResponseCode"));
}
if (httpMetricConfig.containsKey("requestPayloadSize")) {
httpMetric.setRequestPayloadSize(httpMetricConfig.getInt("requestPayloadSize"));
httpMetric.setRequestPayloadSize((int) httpMetricConfig.getDouble("requestPayloadSize"));
}
if (httpMetricConfig.containsKey("responsePayloadSize")) {
httpMetric.setResponsePayloadSize(httpMetricConfig.getInt("responsePayloadSize"));
httpMetric.setResponsePayloadSize((int) httpMetricConfig.getDouble("responsePayloadSize"));
}
if (httpMetricConfig.containsKey("responseContentType")) {

13
packages/perf/e2e/HttpMetric.e2e.js
View File

@@ -62,6 +62,19 @@ android.describe('perf()', () => {
await httpMetric.stop();
should.equal(await httpMetric.stop(), null);
});
it('handles floating point numbers', async () => {
const httpMetric = firebase.perf().newHttpMetric(aCoolUrl, 'POST');
await httpMetric.start();
const floatingPoint = 500.447553;
httpMetric.setHttpResponseCode(floatingPoint);
httpMetric.setResponsePayloadSize(floatingPoint);
httpMetric.setRequestPayloadSize(floatingPoint);
await Utils.sleep(100);
await httpMetric.stop();
});
});
// describe('removeAttribute()', async () => {