kylefang/react-native-firebase
1
0
Fork 0
mirror of https://github.com/zhigang1992/react-native-firebase.git synced 2026-05-03 14:35:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make sure the promise is resolved/rejected for transaction

Browse Source 
Right now the following code will be broken:
```
async function() {
  await ref.transaction(
              function(foo) {
                 // deal with foo
              },
              function(error, committed, ss) {
                 // additional work on complete callback
              },
              true
          );
  // NOTE: Code from here will never execute because promise above never gets resolved
}
```
v2 is not returning at the point of calling onComplete, v3 code does
This commit is contained in:
Elton Gao
2017-11-09 10:34:52 -05:00
committed by Elton Gao
parent 89ce31689e
commit 0c550f3586
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/modules/database/reference.js
View File

@@ -195,8 +195,11 @@ export default class Reference extends ReferenceBase {
return new Promise((resolve, reject) => {
const onCompleteWrapper = (error, committed, snapshotData) => {
if (isFunction(onComplete)) {
if (error) return onComplete(error, committed, null);
return onComplete(null, committed, new Snapshot(this, snapshotData));
if (error) {
onComplete(error, committed, null);
} else {
onComplete(null, committed, new Snapshot(this, snapshotData));
}
}
if (error) return reject(error);