From 0810cfc9ef6f06349c4652e8ab8ff748ac22fecc Mon Sep 17 00:00:00 2001 From: ehesp Date: Thu, 3 Oct 2019 11:54:28 +0100 Subject: [PATCH] Fix #2532 --- packages/firestore/lib/utils/index.js | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/packages/firestore/lib/utils/index.js b/packages/firestore/lib/utils/index.js index 8c7aba68..f6c89a5f 100644 --- a/packages/firestore/lib/utils/index.js +++ b/packages/firestore/lib/utils/index.js @@ -58,7 +58,7 @@ export function parseUpdateArgs(args) { if (isString(key)) { data[key] = value; } else if (key instanceof FirestoreFieldPath) { - data = mergeFieldPathData(data, key._segments, value); + data[key._toPath()] = value; } else { throw new Error(`argument at index ${i} must be a string or FieldPath`); } @@ -141,25 +141,6 @@ function buildFieldPathData(segments, value) { }; } -export function mergeFieldPathData(data, segments, value) { - if (segments.length === 1) { - return { - ...data, - [segments[0]]: value, - }; - } - if (data[segments[0]]) { - return { - ...data, - [segments[0]]: mergeFieldPathData(data[segments[0]], segments.slice(1), value), - }; - } - return { - ...data, - [segments[0]]: buildFieldPathData(segments.slice(1), value), - }; -} - export function parseSnapshotArgs(args) { if (args.length === 0) { throw new Error('expected at least one argument.');