From f42bd71ccc3388d1d4ebf5d6d79d0aaf1fb97cd8 Mon Sep 17 00:00:00 2001 From: Geoffrey Goh Date: Fri, 5 Feb 2016 23:01:28 -0800 Subject: [PATCH] feedback --- CodePush.m | 4 ++-- .../src/main/java/com/microsoft/codepush/react/CodePush.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CodePush.m b/CodePush.m index 7be8e53..1500f48 100644 --- a/CodePush.m +++ b/CodePush.m @@ -506,8 +506,8 @@ RCT_EXPORT_METHOD(isFirstRun:(NSString *)packageHash RCT_EXPORT_METHOD(notifyApplicationReady:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) { - // We only mark a pending update as succeeded only if it update has been booted up, - // during which `_isFirstRunAfterUpdate` is true. + // We only mark a pending update as succeeded only if it has been booted up + // successfully, during which `didUpdate` is set to true. if (_isFirstRunAfterUpdate) { [CodePush removePendingUpdate]; } diff --git a/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java b/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java index aad6a00..fbefe9a 100644 --- a/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java +++ b/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java @@ -539,8 +539,8 @@ public class CodePush { @ReactMethod public void notifyApplicationReady(Promise promise) { - // We only mark a pending update as succeeded only if it update has been booted up, - // during which `didUpdate` is true. + // We only mark a pending update as succeeded only if it has been booted up + // successfully, during which `didUpdate` is set to true. if (didUpdate) { removePendingUpdate(); }