From e4dc02f47af9cc36b0e7f49bc5dcd4a70eb4117d Mon Sep 17 00:00:00 2001 From: Jonathan Carter Date: Mon, 23 Nov 2015 17:33:23 -0800 Subject: [PATCH] Removing 'Name' suffix --- CodePush.h | 6 +++--- CodePush.m | 6 +++--- README.md | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/CodePush.h b/CodePush.h index 6ed5f9c..d24387b 100644 --- a/CodePush.h +++ b/CodePush.h @@ -4,10 +4,10 @@ + (NSURL *)bundleURL; -+ (NSURL *)bundleURLForResourceName:(NSString *)resourceName; ++ (NSURL *)bundleURLForResource:(NSString *)resourceName; -+ (NSURL *)bundleURLForResourceName:(NSString *)resourceName - withExtension:(NSString *)resourceExtension; ++ (NSURL *)bundleURLForResource:(NSString *)resourceName + withExtension:(NSString *)resourceExtension; + (NSString *)getDocumentsDirectory; diff --git a/CodePush.m b/CodePush.m index 528c934..dfa5a0a 100644 --- a/CodePush.m +++ b/CodePush.m @@ -30,14 +30,14 @@ static NSString * const PendingUpdateRollbackTimeoutKey = @"rollbackTimeout"; return [self bundleURLForResourceName:@"main"]; } -+ (NSURL *)bundleURLForResourceName:(NSString *)resourceName ++ (NSURL *)bundleURLForResource:(NSString *)resourceName { return [self bundleURLForResourceName:resourceName withExtension:@"jsbundle"]; } -+ (NSURL *)bundleURLForResourceName:(NSString *)resourceName - withExtension:(NSString *)resourceExtension ++ (NSURL *)bundleURLForResource:(NSString *)resourceName + withExtension:(NSString *)resourceExtension { NSError *error; NSString *packageFile = [CodePushPackage getCurrentPackageBundlePath:&error]; diff --git a/README.md b/README.md index 5c14640..47df67d 100644 --- a/README.md +++ b/README.md @@ -74,7 +74,7 @@ Once your Xcode project has been setup to build/link the CodePush plugin, you ne This change configures your app to always load the most recent version of your app's JS bundle. On the initial launch, this will correspond to the file that was compiled with the app. However, after an update has been pushed via CodePush, this will return the location of the most recently installed update. -*NOTE: The `bundleURL` method assumes your app's JS bundle is named `main.jsbundle`. If you have configured your app to use a different file name, simply call the `bundleURLForResourceName:` method (which assumes you're using the `.jsbundle` extension) or `bundleURLForResourceName:withExtension:` method instead, in order to overwrite that default behavior* +*NOTE: The `bundleURL` method assumes your app's JS bundle is named `main.jsbundle`. If you have configured your app to use a different file name, simply call the `bundleURLForResource:` method (which assumes you're using the `.jsbundle` extension) or `bundleURLForResource:withExtension:` method instead, in order to overwrite that default behavior* To let the CodePush runtime know which deployment it should query for updates against, perform the following steps: