From dfe154de5c11c0b2f1ef68c6b4046643f95a3f70 Mon Sep 17 00:00:00 2001 From: Tomas Roos Date: Wed, 2 Aug 2017 11:46:28 +0200 Subject: [PATCH] Remove overriden createJSModules (#895) Since of recently in master the unused createJSModules has been removed and ReactPackage's no longer contain the definition of createJSModules. There for it must be removed in order to not yield a compile error. This is breaking change. https://github.com/facebook/react-native/commit/ce6fb337a146e6f261f2afb564aa19363774a7a8 --- .../src/main/java/com/microsoft/codepush/react/CodePush.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java b/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java index 22b7f3c..254d61a 100644 --- a/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java +++ b/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java @@ -302,11 +302,6 @@ public class CodePush implements ReactPackage { return nativeModules; } - @Override - public List> createJSModules() { - return new ArrayList<>(); - } - @Override public List createViewManagers(ReactApplicationContext reactApplicationContext) { return new ArrayList<>();