From 3e53a84a02d232c38c304a70241dbc6ae1259146 Mon Sep 17 00:00:00 2001 From: Geoffrey Goh Date: Mon, 8 Feb 2016 16:38:14 -0800 Subject: [PATCH 1/2] fix-failing-tests --- .../CheckForUpdateTests/testcases/NewUpdateTest.js | 4 +--- .../CheckForUpdateTests/testcases/NoRemotePackageTest.js | 2 +- .../testcases/RemotePackageAppVersionNewerTest.js | 2 +- .../CheckForUpdateTests/testcases/SamePackageTest.js | 2 +- .../CheckForUpdateTests/testcases/SwitchDeploymentKeyTest.js | 2 +- .../DownloadProgressTests/resources/TestPackages.js | 2 +- .../DownloadProgressTests/testcases/DownloadProgressTest.js | 2 +- .../InstallUpdateTests/resources/remotePackage.js | 2 +- .../CodePushDemoAppTests/utils/mockAcquisitionSdk.js | 4 ++-- 9 files changed, 10 insertions(+), 12 deletions(-) diff --git a/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NewUpdateTest.js b/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NewUpdateTest.js index 8f196c7..419fc5d 100644 --- a/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NewUpdateTest.js +++ b/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NewUpdateTest.js @@ -1,5 +1,3 @@ -"use strict"; - import React from "react-native"; import CodePush from "react-native-code-push"; import createTestCaseComponent from "../../utils/createTestCaseComponent"; @@ -27,4 +25,4 @@ let NewUpdateTest = createTestCaseComponent( } ); -export default NewUpdateTest; \ No newline at end of file +module.exports = NewUpdateTest; \ No newline at end of file diff --git a/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NoRemotePackageTest.js b/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NoRemotePackageTest.js index 2264832..d22c773 100644 --- a/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NoRemotePackageTest.js +++ b/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NoRemotePackageTest.js @@ -28,4 +28,4 @@ let NoRemotePackageTest = createTestCaseComponent( } ); -export default NoRemotePackageTest; \ No newline at end of file +module.exports = NoRemotePackageTest; \ No newline at end of file diff --git a/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/RemotePackageAppVersionNewerTest.js b/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/RemotePackageAppVersionNewerTest.js index db22e67..5b33054 100644 --- a/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/RemotePackageAppVersionNewerTest.js +++ b/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/RemotePackageAppVersionNewerTest.js @@ -28,4 +28,4 @@ let RemotePackageAppVersionNewerTest = createTestCaseComponent( } ); -export default RemotePackageAppVersionNewerTest; \ No newline at end of file +module.exports = RemotePackageAppVersionNewerTest; \ No newline at end of file diff --git a/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/SamePackageTest.js b/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/SamePackageTest.js index 76aac9a..29d21e4 100644 --- a/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/SamePackageTest.js +++ b/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/SamePackageTest.js @@ -28,4 +28,4 @@ let SamePackageTest = createTestCaseComponent( } ); -export default SamePackageTest; \ No newline at end of file +module.exports = SamePackageTest; \ No newline at end of file diff --git a/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/SwitchDeploymentKeyTest.js b/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/SwitchDeploymentKeyTest.js index 74628ba..e312a74 100644 --- a/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/SwitchDeploymentKeyTest.js +++ b/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/SwitchDeploymentKeyTest.js @@ -29,4 +29,4 @@ let SwitchDeploymentKeyTest = createTestCaseComponent( } ); -export default SwitchDeploymentKeyTest; \ No newline at end of file +module.exports = SwitchDeploymentKeyTest; \ No newline at end of file diff --git a/Examples/CodePushDemoApp/CodePushDemoAppTests/DownloadProgressTests/resources/TestPackages.js b/Examples/CodePushDemoApp/CodePushDemoAppTests/DownloadProgressTests/resources/TestPackages.js index d13201c..de35eb1 100644 --- a/Examples/CodePushDemoApp/CodePushDemoAppTests/DownloadProgressTests/resources/TestPackages.js +++ b/Examples/CodePushDemoApp/CodePushDemoAppTests/DownloadProgressTests/resources/TestPackages.js @@ -44,4 +44,4 @@ packages.forEach((aPackage) => { } }); -export default packages; +module.exports = packages; diff --git a/Examples/CodePushDemoApp/CodePushDemoAppTests/DownloadProgressTests/testcases/DownloadProgressTest.js b/Examples/CodePushDemoApp/CodePushDemoAppTests/DownloadProgressTests/testcases/DownloadProgressTest.js index ac419e3..ee85ca5 100644 --- a/Examples/CodePushDemoApp/CodePushDemoAppTests/DownloadProgressTests/testcases/DownloadProgressTest.js +++ b/Examples/CodePushDemoApp/CodePushDemoAppTests/DownloadProgressTests/testcases/DownloadProgressTest.js @@ -50,4 +50,4 @@ let DownloadProgressTest = createTestCaseComponent( } ); -export default DownloadProgressTest; \ No newline at end of file +module.exports = DownloadProgressTest; \ No newline at end of file diff --git a/Examples/CodePushDemoApp/CodePushDemoAppTests/InstallUpdateTests/resources/remotePackage.js b/Examples/CodePushDemoApp/CodePushDemoAppTests/InstallUpdateTests/resources/remotePackage.js index d974260..e3746c6 100644 --- a/Examples/CodePushDemoApp/CodePushDemoAppTests/InstallUpdateTests/resources/remotePackage.js +++ b/Examples/CodePushDemoApp/CodePushDemoAppTests/InstallUpdateTests/resources/remotePackage.js @@ -1,4 +1,4 @@ -export default { +module.exports = { deploymentKey: "myKey123", description: "Angry flappy birds", appVersion: "1.5.0", diff --git a/Examples/CodePushDemoApp/CodePushDemoAppTests/utils/mockAcquisitionSdk.js b/Examples/CodePushDemoApp/CodePushDemoAppTests/utils/mockAcquisitionSdk.js index ffff99b..9b699d9 100644 --- a/Examples/CodePushDemoApp/CodePushDemoAppTests/utils/mockAcquisitionSdk.js +++ b/Examples/CodePushDemoApp/CodePushDemoAppTests/utils/mockAcquisitionSdk.js @@ -13,12 +13,12 @@ function createMockAcquisitionSdk(serverPackage, localPackage, expectedDeploymen callback(/*err:*/ null, serverPackage); }; - AcquisitionManager.prototype.reportStatusDeploy = (package, status, callback) => { + AcquisitionManager.prototype.reportStatusDeploy = (deployedPackage, status, callback) => { // No-op and return success. callback(null, null); }; - AcquisitionManager.prototype.reportStatusDownload = (package, callback) => { + AcquisitionManager.prototype.reportStatusDownload = (downloadedPackage, callback) => { // No-op and return success. callback(null, null); }; From 8b3e0e6fbd089e44df0123a76e16249d95db9317 Mon Sep 17 00:00:00 2001 From: Geoffrey Goh Date: Mon, 8 Feb 2016 16:39:26 -0800 Subject: [PATCH 2/2] fix-failing-tests --- .../CheckForUpdateTests/testcases/NewUpdateTest.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NewUpdateTest.js b/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NewUpdateTest.js index 419fc5d..f3e74d3 100644 --- a/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NewUpdateTest.js +++ b/Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NewUpdateTest.js @@ -1,3 +1,5 @@ +"use strict"; + import React from "react-native"; import CodePush from "react-native-code-push"; import createTestCaseComponent from "../../utils/createTestCaseComponent";