From c7b6dd28911d0b4882d1554e99cfae1e81f831cb Mon Sep 17 00:00:00 2001 From: Jonathan Carter Date: Mon, 18 Apr 2016 09:45:14 -0700 Subject: [PATCH] Fixing typos --- CodePush.js | 4 ++-- README.md | 2 +- .../main/java/com/microsoft/codepush/react/CodePush.java | 6 ++---- ios/CodePush/CodePush.m | 6 ++---- 4 files changed, 7 insertions(+), 11 deletions(-) diff --git a/CodePush.js b/CodePush.js index 7e98762..16ff92d 100644 --- a/CodePush.js +++ b/CodePush.js @@ -106,8 +106,8 @@ async function getCurrentPackage() { async function getUpdateMetadata(updateState) { const updateMetadata = await NativeCodePush.getUpdateMetadata(updateState || CodePush.UpdateState.RUNNING); if (updateMetadata) { - updateMetadata.failedInstall = await NativeCodePush.isFailedUpdate(updateMetadata.packageHash); - updateMetadata.isFirstRun = await NativeCodePush.isFirstRun(updateMetadata.packageHash); + updateMetadata.failedInstall = await NativeCodePush.isFailedUpdate(updateMetadata.packageHash); + updateMetadata.isFirstRun = await NativeCodePush.isFirstRun(updateMetadata.packageHash); } return updateMetadata; } diff --git a/README.md b/README.md index d95d6f9..27e4c05 100644 --- a/README.md +++ b/README.md @@ -441,7 +441,7 @@ Example Usage: ```javascript // Check if there is currently a CodePush update running, and if // so, register it with the HockeyApp SDK (https://github.com/slowpath/react-native-hockeyapp) -// so that crash reports will correctly display the JS bundle version the user was running. +// so that crash reports will correctly display the JS bundle version the user was running. codePush.getUpdateMetadata().then((update) => { if (update) { hockeyApp.addMetadata({ CodePushRelease: update.label }); diff --git a/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java b/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java index b6526da..e4ee090 100644 --- a/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java +++ b/android/app/src/main/java/com/microsoft/codepush/react/CodePush.java @@ -519,8 +519,7 @@ public class CodePush implements ReactPackage { // The current package satisfies the request: // 1) Caller wanted a pending, and there is a pending update // 2) Caller wanted the running update, and there isn't a pending - // 3) Calers wants the latest update, regardless if it's pending or not - + // 3) Caller wants the latest update, regardless if it's pending or not if (isRunningBinaryVersion) { // This only matters in Debug builds. Since we do not clear "outdated" updates, // we need to indicate to the JS side that somehow we have a current update on @@ -528,8 +527,7 @@ public class CodePush implements ReactPackage { currentPackage.putBoolean("_isDebugOnly", true); } - // To support differentiating pending vs. non-pending updates - // when request an update state of LATEST, provide an isPending flag + // Enable differentiating pending vs. non-pending updates currentPackage.putBoolean("isPending", currentUpdateIsPending); promise.resolve(currentPackage); } diff --git a/ios/CodePush/CodePush.m b/ios/CodePush/CodePush.m index 1fc223d..e57233b 100644 --- a/ios/CodePush/CodePush.m +++ b/ios/CodePush/CodePush.m @@ -569,8 +569,7 @@ RCT_EXPORT_METHOD(getUpdateMetadata:(CodePushUpdateState)updateState // The current package satisfies the request: // 1) Caller wanted a pending, and there is a pending update // 2) Caller wanted the running update, and there isn't a pending - // 3) Calers wants the latest update, regardless if it's pending or not - + // 3) Caller wants the latest update, regardless if it's pending or not if (isRunningBinaryVersion) { // This only matters in Debug builds. Since we do not clear "outdated" updates, // we need to indicate to the JS side that somehow we have a current update on @@ -578,8 +577,7 @@ RCT_EXPORT_METHOD(getUpdateMetadata:(CodePushUpdateState)updateState [package setObject:@(YES) forKey:@"_isDebugOnly"]; } - // To support differentiating pending vs. non-pending updates - // when request an update state of LATEST, provide an isPending flag + // Enable differentiating pending vs. non-pending updates [package setObject:@(currentUpdateIsPending) forKey:PackageIsPendingKey]; resolve(package); }