From 4aee947294cd74eb2834b77eb4eeca0dc5a6102f Mon Sep 17 00:00:00 2001 From: Tim Scott Date: Fri, 10 Mar 2017 20:32:09 -0600 Subject: [PATCH] Update README.md (#751) * Update README.md When I fail to supply a CODEPUSH_KEY variable for debug, the build fails. This pull fixes the example code. I also added a comment letting developers know to expect errors from CodePush in debug mode. (This behavior is surprising, but I believe is by design.) * Tweak comment --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 3fba370..b624fc5 100644 --- a/README.md +++ b/README.md @@ -256,7 +256,8 @@ To set this up, perform the following steps: buildTypes { debug { ... - // CodePush updates should not be tested in Debug mode + // Note: CodePush updates should not be tested in Debug mode as they are overriden by the RN packager. However, because CodePush checks for updates in all modes, we must supply a key. + buildConfigField "String", "CODEPUSH_KEY", '""' ... }